build/common.gypi - Issue 206006: Force inclusion of build/common.gypi for all chromium gyp files.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/common.gypi

Issue 206006: Force inclusion of build/common.gypi for all chromium gyp files. (Closed)

Patch Set: 2nd round of feedback Created 11 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/common.gypi

diff --git a/build/common.gypi b/build/common.gypi

index aeb5d111ad29c2c80c2ecbca02f465b27c77a462..1904f408b2ad0a343d46b0e5bed0c7157afab9a3 100644

--- a/build/common.gypi

+++ b/build/common.gypi

@@ -2,6 +2,9 @@

# Use of this source code is governed by a BSD-style license that can be

# found in the LICENSE file.

+# IMPORTANT:

+# Please don't directly include this file if you are building via gyp_chromium,

+# since gyp_chromium is automatically forcing its inclusion.

{

Mark Mentovai 2009/09/15 21:49:57 Nit: leave a blank line between your comment block

'variables': {

# .gyp files should set chromium_code to 1 if they build Chromium-specific

« no previous file with comments | « build/all.gyp ('k') | build/gyp_chromium » ('j') | o3d/DEPS_gyp » ('J')