Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Side by Side Diff: build/common.gypi

Issue 206006: Force inclusion of build/common.gypi for all chromium gyp files. (Closed)
Patch Set: 2nd round of feedback Created 11 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « build/all.gyp ('k') | build/gyp_chromium » ('j') | o3d/DEPS_gyp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2009 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2009 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # IMPORTANT:
6 # Please don't directly include this file if you are building via gyp_chromium,
7 # since gyp_chromium is automatically forcing its inclusion.
5 { 8 {
Mark Mentovai 2009/09/15 21:49:57 Nit: leave a blank line between your comment block
6 'variables': { 9 'variables': {
7 # .gyp files should set chromium_code to 1 if they build Chromium-specific 10 # .gyp files should set chromium_code to 1 if they build Chromium-specific
8 # code, as opposed to external code. This variable is used to control 11 # code, as opposed to external code. This variable is used to control
9 # such things as the set of warnings to enable, and whether warnings are 12 # such things as the set of warnings to enable, and whether warnings are
10 # treated as errors. 13 # treated as errors.
11 'chromium_code%': 0, 14 'chromium_code%': 0,
12 15
13 # Variables expected to be overriden on the GYP command line (-D) or by 16 # Variables expected to be overriden on the GYP command line (-D) or by
14 # ~/.gyp/include.gypi. 17 # ~/.gyp/include.gypi.
15 18
(...skipping 773 matching lines...) Expand 10 before | Expand all | Expand 10 after
789 # settings in target dicts. SYMROOT is a special case, because many other 792 # settings in target dicts. SYMROOT is a special case, because many other
790 # Xcode variables depend on it, including variables such as 793 # Xcode variables depend on it, including variables such as
791 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something 794 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something
792 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the 795 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the
793 # files to appear (when present) in the UI as actual files and not red 796 # files to appear (when present) in the UI as actual files and not red
794 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR, 797 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR,
795 # and therefore SYMROOT, needs to be set at the project level. 798 # and therefore SYMROOT, needs to be set at the project level.
796 'SYMROOT': '<(DEPTH)/xcodebuild', 799 'SYMROOT': '<(DEPTH)/xcodebuild',
797 }, 800 },
798 } 801 }
OLDNEW
« no previous file with comments | « build/all.gyp ('k') | build/gyp_chromium » ('j') | o3d/DEPS_gyp » ('J')

Powered by Google App Engine
This is Rietveld 408576698