third_party/harfbuzz/harfbuzz.gyp - Issue 206006: Force inclusion of build/common.gypi for all chromium gyp files.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/harfbuzz/harfbuzz.gyp

Issue 206006: Force inclusion of build/common.gypi for all chromium gyp files. (Closed)

Patch Set: 2nd round of feedback Created 11 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/harfbuzz/harfbuzz.gyp

diff --git a/third_party/harfbuzz/harfbuzz.gyp b/third_party/harfbuzz/harfbuzz.gyp

index b19680a2290666efc30defff3fd9d774a5fadeb3..1e3296f6be0bec3be0fcc85ca695cee51a74754e 100644

--- a/third_party/harfbuzz/harfbuzz.gyp

+++ b/third_party/harfbuzz/harfbuzz.gyp

@@ -3,9 +3,6 @@

# found in the LICENSE file.

{

- 'includes': [

- '../../build/common.gypi',

- ],

'targets': [

{

'target_name': 'harfbuzz',