base/base.gyp - Issue 206006: Force inclusion of build/common.gypi for all chromium gyp files.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/base.gyp

Issue 206006: Force inclusion of build/common.gypi for all chromium gyp files. (Closed)

Patch Set: 2nd round of feedback Created 11 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/base.gyp

diff --git a/base/base.gyp b/base/base.gyp

index 8c0ed39b0a2dda577860230c03b482aa4d6aee57..c56839de04f460187897e077c120d5d467920336 100644

--- a/base/base.gyp

+++ b/base/base.gyp

@@ -6,9 +6,6 @@

'variables': {

'chromium_code': 1,

- 'includes': [

- '../build/common.gypi',

- ],

'targets': [

{

'target_name': 'base',

« no previous file with comments | « app/app.gyp ('k') | breakpad/breakpad.gyp » ('j') | build/common.gypi » ('J')