Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 12842: Move convolver, image_operations, and skia_utils from base/gfx to skia/ext.... (Closed)

Created:
12 years ago by brettw
Modified:
9 years, 7 months ago
Reviewers:
dglazkov
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Move convolver, image_operations, and skia_utils from base/gfx to skia/ext. This changes the namespace in those files from "gfx" to "skia". I split skia_utils into two parts, the Windows specific part is now in a separate file called skia_utils_win. There were several obsolete includes of these headers which I removed. I also removed img_resize_perftest which isn't used and has bitrotted. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=6248

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+205 lines, -1803 lines) Patch
M base/build/base_gfx.vcproj View 3 chunks +0 lines, -24 lines 0 comments Download
M base/build/base_unittests.vcproj View 1 chunk +0 lines, -8 lines 0 comments Download
M base/gfx/base_gfx.scons View 2 chunks +0 lines, -4 lines 0 comments Download
D base/gfx/convolver.h View 1 chunk +0 lines, -137 lines 0 comments Download
D base/gfx/convolver.cc View 1 chunk +0 lines, -335 lines 0 comments Download
D base/gfx/convolver_unittest.cc View 1 chunk +0 lines, -127 lines 0 comments Download
D base/gfx/image_operations.h View 1 chunk +0 lines, -63 lines 0 comments Download
D base/gfx/image_operations.cc View 1 chunk +0 lines, -362 lines 0 comments Download
D base/gfx/image_operations_unittest.cc View 1 chunk +0 lines, -148 lines 0 comments Download
D base/gfx/img_resize_perftest.cc View 1 chunk +0 lines, -70 lines 0 comments Download
M base/gfx/native_theme.cc View 5 chunks +6 lines, -6 lines 0 comments Download
D base/gfx/skia_utils.h View 1 chunk +0 lines, -56 lines 0 comments Download
D base/gfx/skia_utils.cc View 1 chunk +0 lines, -75 lines 0 comments Download
D base/gfx/skia_utils_mac.h View 1 chunk +0 lines, -51 lines 0 comments Download
D base/gfx/skia_utils_mac.cc View 1 chunk +0 lines, -83 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_edit.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/download/download_util.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/fav_icon_helper.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/importer/importer.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/views/bookmark_bar_view.cc View 6 chunks +15 lines, -15 lines 0 comments Download
M chrome/browser/views/bookmark_manager_view.cc View 3 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/views/options/content_page_view.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/views/options/fonts_page_view.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/views/options/languages_page_view.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/views/options/options_group_view.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/views/sad_tab_view.cc View 2 chunks +3 lines, -10 lines 0 comments Download
M chrome/browser/views/tabs/tab_renderer.cc View 1 2 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/common/gfx/color_utils.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/common/gfx/icon_util.cc View 1 2 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/renderer/render_view.cc View 1 2 4 chunks +3 lines, -4 lines 0 comments Download
M chrome/views/background.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/views/button.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/views/chrome_menu.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/views/single_split_view.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/views/tabbed_pane.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/views/table_view.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/views/text_field.cc View 3 chunks +2 lines, -3 lines 0 comments Download
M skia/SConscript View 2 chunks +6 lines, -0 lines 0 comments Download
A + skia/ext/convolver.h View 1 3 chunks +5 lines, -5 lines 0 comments Download
A + skia/ext/convolver.cc View 1 2 chunks +4 lines, -3 lines 0 comments Download
A + skia/ext/convolver_unittest.cc View 1 2 chunks +4 lines, -3 lines 0 comments Download
A + skia/ext/image_operations.h View 1 2 3 chunks +8 lines, -8 lines 0 comments Download
A + skia/ext/image_operations.cc View 1 2 3 chunks +9 lines, -5 lines 0 comments Download
A + skia/ext/image_operations_unittest.cc View 1 4 chunks +10 lines, -9 lines 0 comments Download
M skia/ext/platform_device_win.cc View 1 chunk +4 lines, -1 line 0 comments Download
A + skia/ext/skia_utils.h View 1 chunk +7 lines, -40 lines 0 comments Download
A + skia/ext/skia_utils.cc View 2 chunks +3 lines, -52 lines 0 comments Download
A + skia/ext/skia_utils_mac.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + skia/ext/skia_utils_mac.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + skia/ext/skia_utils_win.h View 3 chunks +5 lines, -5 lines 0 comments Download
A + skia/ext/skia_utils_win.cc View 3 chunks +19 lines, -35 lines 0 comments Download
M skia/ext/vector_device.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M skia/skia.vcproj View 2 chunks +32 lines, -0 lines 0 comments Download
M webkit/port/platform/graphics/FontWin.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M webkit/port/platform/graphics/ImageSkia.cpp View 1 2 3 chunks +5 lines, -5 lines 0 comments Download
M webkit/port/platform/graphics/NativeImageSkia.cpp View 1 2 2 chunks +5 lines, -5 lines 0 comments Download
M webkit/port/platform/graphics/PlatformContextSkia.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M webkit/port/rendering/RenderThemeWin.cpp View 2 chunks +3 lines, -4 lines 0 comments Download
M webkit/tools/test_shell/test_shell_tests.vcproj View 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
brettw
12 years ago (2008-12-02 00:26:46 UTC) #1
dglazkov
12 years ago (2008-12-02 17:06:40 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698