RefCounted types should not have public destructors, chrome/browser/ui

RefCounted types should not have public destructors, chrome/browser/ui version

BUG=123295
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=133865

[Ryan Sleevi, 2012-04-13 09:01:17]

estade: webui/
thakis: cocoa/

[Evan Stade, 2012-04-13 17:05:20]

webui lgtm

[Nico, 2012-04-13 17:09:11]

mac bits lgtm

http://codereview.chromium.org/10067033/diff/1/chrome/browser/ui/cocoa/select...
File chrome/browser/ui/cocoa/select_file_dialog_mac.mm (right):

http://codereview.chromium.org/10067033/diff/1/chrome/browser/ui/cocoa/select...
chrome/browser/ui/cocoa/select_file_dialog_mac.mm:87: void* params) OVERRIDE;
Huh, I thought avi had made the plugin check for mandatory OVERRIDEs in source
files as well?

[Ryan Sleevi, 2012-04-13 17:23:04]

http://codereview.chromium.org/10067033/diff/1/chrome/browser/ui/cocoa/select...
File chrome/browser/ui/cocoa/select_file_dialog_mac.mm (right):

http://codereview.chromium.org/10067033/diff/1/chrome/browser/ui/cocoa/select...
chrome/browser/ui/cocoa/select_file_dialog_mac.mm:87: void* params) OVERRIDE;
On 2012/04/13 17:09:11, Nico wrote:
> Huh, I thought avi had made the plugin check for mandatory OVERRIDEs in source
> files as well?

No. That's why I split the plugin change into two parts - the first part adds
support for checking implementation files.

While OVERRIDE /works/ if annotated, the style checker doesn't enforce it. I
have a second patch for that - but it's an even larger changeset then this, so
I'm saving that for at least a few more weekends/evenings. This was just some
low hanging fruit.

[commit-bot: I haz the power, 2012-04-25 00:20:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rsleevi@chromium.org/10067033/7012

[commit-bot: I haz the power, 2012-04-25 00:20:45]

Presubmit check for 10067033-7012 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    chrome/browser/ui

Presubmit checks took 2.3s to calculate.

[Ryan Sleevi, 2012-04-25 00:22:29]

sky: Stamp for refactoring?

[sky, 2012-04-25 03:39:56]

LGTM

[commit-bot: I haz the power, 2012-04-25 03:40:56]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rsleevi@chromium.org/10067033/7012

[commit-bot: I haz the power, 2012-04-25 04:02:51]

Try job failure for 10067033-7012 (retry) on linux_chromeos for step "compile"
(clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[commit-bot: I haz the power, 2012-04-25 04:26:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rsleevi@chromium.org/10067033/5002

[commit-bot: I haz the power, 2012-04-25 05:52:31]

Change committed as 133865