Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Unified Diff: chrome/browser/ui/webui/chrome_web_ui_data_source_unittest.cc

Issue 10067033: RefCounted types should not have public destructors, chrome/browser/ui (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Merge fix Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/chrome_web_ui_data_source_unittest.cc
diff --git a/chrome/browser/ui/webui/chrome_web_ui_data_source_unittest.cc b/chrome/browser/ui/webui/chrome_web_ui_data_source_unittest.cc
index a0ff5d89034893bcc0cb2578c7e47d5ab6c41a05..634f647cc365aa6b53a4472979bed16decce5801 100644
--- a/chrome/browser/ui/webui/chrome_web_ui_data_source_unittest.cc
+++ b/chrome/browser/ui/webui/chrome_web_ui_data_source_unittest.cc
@@ -18,9 +18,6 @@ class MockChromeWebUIDataSource : public ChromeWebUIDataSource {
result_data_(NULL) {
}
- virtual ~MockChromeWebUIDataSource() {
- }
-
// Subvert protected methods.
virtual void StartDataRequest(
const std::string& path, bool is_incognito, int request_id) OVERRIDE {
@@ -39,6 +36,9 @@ class MockChromeWebUIDataSource : public ChromeWebUIDataSource {
int result_request_id_;
scoped_refptr<RefCountedMemory> result_data_;
+
+ private:
+ virtual ~MockChromeWebUIDataSource() {}
};
class ChromeWebUIDataSourceTest : public testing::Test {
« no previous file with comments | « chrome/browser/ui/webui/chrome_web_ui_data_source.h ('k') | chrome/browser/ui/webui/extensions/extension_icon_source.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698