Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1773)

Unified Diff: chrome/browser/ui/fullscreen_controller.h

Issue 10067033: RefCounted types should not have public destructors, chrome/browser/ui (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Merge fix Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/cocoa/select_file_dialog_mac.mm ('k') | chrome/browser/ui/fullscreen_controller.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/fullscreen_controller.h
diff --git a/chrome/browser/ui/fullscreen_controller.h b/chrome/browser/ui/fullscreen_controller.h
index 9284c19a545faf7e993bdfec8014dd101a109163..35d09eb5acdab2f33e0947a624be7a3b1a92416a 100644
--- a/chrome/browser/ui/fullscreen_controller.h
+++ b/chrome/browser/ui/fullscreen_controller.h
@@ -37,7 +37,6 @@ class FullscreenController : public base::RefCounted<FullscreenController> {
FullscreenController(BrowserWindow* window,
Profile* profile,
Browser* browser);
- virtual ~FullscreenController();
// Querying.
@@ -81,6 +80,8 @@ class FullscreenController : public base::RefCounted<FullscreenController> {
FullscreenExitBubbleType GetFullscreenExitBubbleType() const;
private:
+ friend class base::RefCounted<FullscreenController>;
+
enum MouseLockState {
MOUSELOCK_NOT_REQUESTED,
// The page requests to lock the mouse and the user hasn't responded to the
@@ -90,6 +91,8 @@ class FullscreenController : public base::RefCounted<FullscreenController> {
MOUSELOCK_ACCEPTED
};
+ virtual ~FullscreenController();
+
// Notifies the tab that it has been forced out of fullscreen mode if
// necessary.
void NotifyTabOfFullscreenExitIfNecessary();
« no previous file with comments | « chrome/browser/ui/cocoa/select_file_dialog_mac.mm ('k') | chrome/browser/ui/fullscreen_controller.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698