RefCounted types should not have public destructors, chrome/browser/ui

chrome/browser/ui/webui/extensions/extension_icon_source.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_WEBUI_EXTENSIONS_EXTENSION_ICON_SOURCE_H_
 #define CHROME_BROWSER_UI_WEBUI_EXTENSIONS_EXTENSION_ICON_SOURCE_H_
 #pragma once
 
 #include <map>
 #include <string>
@@ skipping 31 matching lines @@
 //
 // We attempt to load icons from the following sources in order:
 //  1) The icons as listed in the extension / app manifests.
 //  2) If a 16px icon was requested, the favicon for extension's launch URL.
 //  3) The default extension / application icon if there are still no matches.
 //
 class ExtensionIconSource : public ChromeURLDataManager::DataSource,
                             public ImageLoadingTracker::Observer {
  public:
   explicit ExtensionIconSource(Profile* profile);
-  virtual ~ExtensionIconSource();
 
   // Gets the URL of the |extension| icon in the given |icon_size|, falling back
   // based on the |match| type. If |grayscale|, the URL will be for the
   // desaturated version of the icon. |exists|, if non-NULL, will be set to true
   // if the icon exists; false if it will lead to a default or not-present
   // image.
   static GURL GetIconURL(const Extension* extension,
                          int icon_size,
                          ExtensionIconSet::MatchType match,
                          bool grayscale,
                          bool* exists);
 
   // A public utility function for accessing the bitmap of the image specified
   // by |resource_id|.
   static SkBitmap* LoadImageByResourceId(int resource_id);
 
   // ChromeURLDataManager::DataSource
 
   virtual std::string GetMimeType(const std::string&) const OVERRIDE;
 
   virtual void StartDataRequest(const std::string& path,
                                 bool is_incognito,
                                 int request_id) OVERRIDE;
 
  private:
   // Encapsulates the request parameters for |request_id|.
   struct ExtensionIconRequest;
 
+  virtual ~ExtensionIconSource();
+
   // Returns the bitmap for the webstore icon.
   const SkBitmap* GetWebStoreImage();
 
   // Returns the bitmap for the default app image.
   const SkBitmap* GetDefaultAppImage();
 
   // Returns the bitmap for the default extension.
   const SkBitmap* GetDefaultExtensionImage();
 
   // Performs any remaining transformations (like desaturating the |image|),
@@ skipping 67 matching lines @@
   scoped_ptr<SkBitmap> default_app_data_;
 
   scoped_ptr<SkBitmap> default_extension_data_;
 
   CancelableRequestConsumerT<int, 0> cancelable_consumer_;
 
   DISALLOW_COPY_AND_ASSIGN(ExtensionIconSource);
 };
 
 #endif  // CHROME_BROWSER_UI_WEBUI_EXTENSIONS_EXTENSION_ICON_SOURCE_H_