chrome/browser/ui/webui/chrome_web_ui_data_source.h - Issue 10067033: RefCounted types should not have public destructors, chrome/browser/ui

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/chrome_web_ui_data_source.h

Issue 10067033: RefCounted types should not have public destructors, chrome/browser/ui (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Merge fix Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/webui/chrome_web_ui_data_source.h

diff --git a/chrome/browser/ui/webui/chrome_web_ui_data_source.h b/chrome/browser/ui/webui/chrome_web_ui_data_source.h

index 96666fcb8b823f07977b2bb7f679c95b1494c3d0..44b99d662210bd7e618b0c0c370b60474e6d0210 100644

--- a/chrome/browser/ui/webui/chrome_web_ui_data_source.h

+++ b/chrome/browser/ui/webui/chrome_web_ui_data_source.h

@@ -53,9 +53,9 @@ class ChromeWebUIDataSource : public ChromeURLDataManager::DataSource {

default_resource_ = resource_id;

}

+ protected:

virtual ~ChromeWebUIDataSource();

- protected:

// Completes a request by sending our dictionary of localized strings.

void SendLocalizedStringsAsJSON(int request_id);