Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: chrome/browser/ui/webui/options2/options_ui2.cc

Issue 10067033: RefCounted types should not have public destructors, chrome/browser/ui (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Merge fix Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/options2/options_ui2.cc
diff --git a/chrome/browser/ui/webui/options2/options_ui2.cc b/chrome/browser/ui/webui/options2/options_ui2.cc
index 30e7b865082c1f54eafd3a29f167ef6da71aa310..8a1ddfd835c02aa5d40666c268fafd0e4ebd6421 100644
--- a/chrome/browser/ui/webui/options2/options_ui2.cc
+++ b/chrome/browser/ui/webui/options2/options_ui2.cc
@@ -111,7 +111,6 @@ class OptionsUIHTMLSource : public ChromeURLDataManager::DataSource {
public:
// The constructor takes over ownership of |localized_strings|.
explicit OptionsUIHTMLSource(DictionaryValue* localized_strings);
- virtual ~OptionsUIHTMLSource();
// Called when the network layer has requested a resource underneath
// the path we registered.
@@ -121,6 +120,8 @@ class OptionsUIHTMLSource : public ChromeURLDataManager::DataSource {
virtual std::string GetMimeType(const std::string&) const;
private:
+ virtual ~OptionsUIHTMLSource();
+
// Localized strings collection.
scoped_ptr<DictionaryValue> localized_strings_;
@@ -133,8 +134,6 @@ OptionsUIHTMLSource::OptionsUIHTMLSource(DictionaryValue* localized_strings)
localized_strings_.reset(localized_strings);
}
-OptionsUIHTMLSource::~OptionsUIHTMLSource() {}
-
void OptionsUIHTMLSource::StartDataRequest(const std::string& path,
bool is_incognito,
int request_id) {
@@ -166,6 +165,8 @@ std::string OptionsUIHTMLSource::GetMimeType(const std::string& path) const {
return "text/html";
}
+OptionsUIHTMLSource::~OptionsUIHTMLSource() {}
+
////////////////////////////////////////////////////////////////////////////////
//
// OptionsPageUIHandler
« no previous file with comments | « chrome/browser/ui/webui/fileicon_source_unittest.cc ('k') | chrome/browser/ui/webui/quota_internals_proxy.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698