Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(465)

Side by Side Diff: chrome/browser/ui/webui/bookmarks_ui.h

Issue 10067033: RefCounted types should not have public destructors, chrome/browser/ui (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Merge fix Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/ui/webui/about_ui.cc ('k') | chrome/browser/ui/webui/bookmarks_ui.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_WEBUI_BOOKMARKS_UI_H_ 5 #ifndef CHROME_BROWSER_UI_WEBUI_BOOKMARKS_UI_H_
6 #define CHROME_BROWSER_UI_WEBUI_BOOKMARKS_UI_H_ 6 #define CHROME_BROWSER_UI_WEBUI_BOOKMARKS_UI_H_
7 #pragma once 7 #pragma once
8 8
9 #include <string> 9 #include <string>
10 10
11 #include "chrome/browser/ui/webui/chrome_url_data_manager.h" 11 #include "chrome/browser/ui/webui/chrome_url_data_manager.h"
12 #include "content/public/browser/web_ui_controller.h" 12 #include "content/public/browser/web_ui_controller.h"
13 13
14 class RefCountedMemory; 14 class RefCountedMemory;
15 15
16 // This class provides the source for chrome://bookmarks/ 16 // This class provides the source for chrome://bookmarks/
17 class BookmarksUIHTMLSource : public ChromeURLDataManager::DataSource { 17 class BookmarksUIHTMLSource : public ChromeURLDataManager::DataSource {
18 public: 18 public:
19 BookmarksUIHTMLSource(); 19 BookmarksUIHTMLSource();
20 20
21 // Called when the network layer has requested a resource underneath 21 // Called when the network layer has requested a resource underneath
22 // the path we registered. 22 // the path we registered.
23 virtual void StartDataRequest(const std::string& path, 23 virtual void StartDataRequest(const std::string& path,
24 bool is_incognito, 24 bool is_incognito,
25 int request_id) OVERRIDE; 25 int request_id) OVERRIDE;
26 virtual std::string GetMimeType(const std::string& path) const OVERRIDE; 26 virtual std::string GetMimeType(const std::string& path) const OVERRIDE;
27 27
28 private: 28 private:
29 virtual ~BookmarksUIHTMLSource();
30
29 DISALLOW_COPY_AND_ASSIGN(BookmarksUIHTMLSource); 31 DISALLOW_COPY_AND_ASSIGN(BookmarksUIHTMLSource);
30 }; 32 };
31 33
32 // This class is used to hook up chrome://bookmarks/ which in turn gets 34 // This class is used to hook up chrome://bookmarks/ which in turn gets
33 // overridden by an extension. 35 // overridden by an extension.
34 class BookmarksUI : public content::WebUIController { 36 class BookmarksUI : public content::WebUIController {
35 public: 37 public:
36 explicit BookmarksUI(content::WebUI* web_ui); 38 explicit BookmarksUI(content::WebUI* web_ui);
37 39
38 static RefCountedMemory* GetFaviconResourceBytes(); 40 static RefCountedMemory* GetFaviconResourceBytes();
39 41
40 private: 42 private:
41 DISALLOW_COPY_AND_ASSIGN(BookmarksUI); 43 DISALLOW_COPY_AND_ASSIGN(BookmarksUI);
42 }; 44 };
43 45
44 #endif // CHROME_BROWSER_UI_WEBUI_BOOKMARKS_UI_H_ 46 #endif // CHROME_BROWSER_UI_WEBUI_BOOKMARKS_UI_H_
OLDNEW
« no previous file with comments | « chrome/browser/ui/webui/about_ui.cc ('k') | chrome/browser/ui/webui/bookmarks_ui.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698