RefCounted types should not have public destructors, chrome/browser/ui

chrome/browser/ui/webui/extensions/extension_icon_source.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/extensions/extension_icon_source.h"
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/memory/ref_counted_memory.h"
 #include "base/stl_util.h"
@@ skipping 48 matching lines @@
 }
 
 struct ExtensionIconSource::ExtensionIconRequest {
   int request_id;
   const Extension* extension;
   bool grayscale;
   int size;
   ExtensionIconSet::MatchType match;
 };
 
-ExtensionIconSource::~ExtensionIconSource() {
-  // Clean up all the temporary data we're holding for requests.
-  STLDeleteValues(&request_map_);
-}
-
 // static
 GURL ExtensionIconSource::GetIconURL(const Extension* extension,
                                      int icon_size,
                                      ExtensionIconSet::MatchType match,
                                      bool grayscale,
                                      bool* exists) {
   if (exists)
     *exists = true;
   if (exists && extension->GetIconURL(icon_size, match) == GURL())
     *exists = false;
@@ skipping 39 matching lines @@
   ExtensionResource icon =
       request->extension->GetIconResource(request->size, request->match);
 
   if (icon.relative_path().empty()) {
     LoadIconFailed(request_id);
   } else {
     LoadExtensionImage(icon, request_id);
   }
 }
 
-void ExtensionIconSource::LoadIconFailed(int request_id) {
-  ExtensionIconRequest* request = GetData(request_id);
-  ExtensionResource icon =
-      request->extension->GetIconResource(request->size, request->match);
-
-  if (request->size == ExtensionIconSet::EXTENSION_ICON_BITTY)
-    LoadFaviconImage(request_id);
-  else
-    LoadDefaultImage(request_id);
+ExtensionIconSource::~ExtensionIconSource() {
+  // Clean up all the temporary data we're holding for requests.
+  STLDeleteValues(&request_map_);
 }
 
 const SkBitmap* ExtensionIconSource::GetWebStoreImage() {
   if (!web_store_icon_data_.get())
     web_store_icon_data_.reset(LoadImageByResourceId(IDR_WEBSTORE_ICON));
 
   return web_store_icon_data_.get();
 }
 
 const SkBitmap* ExtensionIconSource::GetDefaultAppImage() {
@@ skipping 106 matching lines @@
                                         int index) {
   int request_id = tracker_map_[index];
   tracker_map_.erase(tracker_map_.find(index));
 
   if (image.IsEmpty())
     LoadIconFailed(request_id);
   else
     FinalizeImage(image.ToSkBitmap(), request_id);
 }
 
+void ExtensionIconSource::LoadIconFailed(int request_id) {
+  ExtensionIconRequest* request = GetData(request_id);
+  ExtensionResource icon =
+      request->extension->GetIconResource(request->size, request->match);
+
+  if (request->size == ExtensionIconSet::EXTENSION_ICON_BITTY)
+    LoadFaviconImage(request_id);
+  else
+    LoadDefaultImage(request_id);
+}
+
 bool ExtensionIconSource::ParseData(const std::string& path,
                                     int request_id) {
   // Extract the parameters from the path by lower casing and splitting.
   std::string path_lower = StringToLowerASCII(path);
   std::vector<std::string> path_parts;
 
   base::SplitString(path_lower, '/', &path_parts);
   if (path_lower.empty() || path_parts.size() < 3)
     return false;
 
@@ skipping 58 matching lines @@
 
 void ExtensionIconSource::ClearData(int request_id) {
   std::map<int, ExtensionIconRequest*>::iterator i =
       request_map_.find(request_id);
   if (i == request_map_.end())
     return;
 
   delete i->second;
   request_map_.erase(i);
 }