Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 998283002: [turbofan] Introduce optional Float64Min and Float64Max machine operators. (Closed)

Created:
5 years, 9 months ago by Benedikt Meurer
Modified:
5 years, 9 months ago
Reviewers:
dcarney
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Introduce optional Float64Min and Float64Max machine operators. Basically recognize certain x < y ? x : y constructs and turn that into Float64Min/Float64Max operations, if the target machine supports that. On x86 we lower to (v)minsd/(v)maxsd. R=dcarney@chromium.org Committed: https://crrev.com/99f8d57f3c5d967bc3b10356b22d7ec7be55e89f Cr-Commit-Position: refs/heads/master@{#27160}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+478 lines, -31 lines) Patch
M src/compiler/arm/instruction-selector-arm.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/compiler/arm64/instruction-selector-arm64.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/compiler/common-operator-reducer.h View 1 chunk +20 lines, -1 line 0 comments Download
M src/compiler/common-operator-reducer.cc View 2 chunks +109 lines, -15 lines 0 comments Download
M src/compiler/ia32/code-generator-ia32.cc View 2 chunks +18 lines, -0 lines 0 comments Download
M src/compiler/ia32/instruction-codes-ia32.h View 2 chunks +4 lines, -0 lines 0 comments Download
M src/compiler/ia32/instruction-selector-ia32.cc View 2 chunks +26 lines, -0 lines 0 comments Download
M src/compiler/instruction-selector.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M src/compiler/machine-operator.h View 2 chunks +14 lines, -6 lines 0 comments Download
M src/compiler/machine-operator.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/opcodes.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/pipeline.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/compiler/simplified-lowering.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/typer.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M src/compiler/verifier.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/x64/code-generator-x64.cc View 2 chunks +12 lines, -0 lines 0 comments Download
M src/compiler/x64/instruction-codes-x64.h View 2 chunks +4 lines, -0 lines 0 comments Download
M src/compiler/x64/instruction-selector-x64.cc View 2 chunks +26 lines, -0 lines 0 comments Download
M src/ia32/assembler-ia32.h View 2 chunks +17 lines, -0 lines 0 comments Download
M src/ia32/assembler-ia32.cc View 1 chunk +18 lines, -0 lines 0 comments Download
M src/ia32/disasm-ia32.cc View 2 chunks +16 lines, -0 lines 0 comments Download
M src/x64/assembler-x64.h View 2 chunks +17 lines, -0 lines 0 comments Download
M src/x64/assembler-x64.cc View 1 chunk +40 lines, -0 lines 0 comments Download
M src/x64/disasm-x64.cc View 2 chunks +14 lines, -0 lines 0 comments Download
M test/cctest/test-disasm-ia32.cc View 2 chunks +8 lines, -0 lines 0 comments Download
M test/cctest/test-disasm-x64.cc View 2 chunks +9 lines, -1 line 0 comments Download
M test/unittests/compiler/common-operator-reducer-unittest.cc View 5 chunks +60 lines, -4 lines 0 comments Download
M test/unittests/compiler/machine-operator-unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M test/unittests/compiler/node-test-utils.h View 1 chunk +4 lines, -0 lines 0 comments Download
M test/unittests/compiler/node-test-utils.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Benedikt Meurer
5 years, 9 months ago (2015-03-12 13:41:59 UTC) #1
Benedikt Meurer
PTAL
5 years, 9 months ago (2015-03-12 13:42:27 UTC) #2
dcarney
lgtm
5 years, 9 months ago (2015-03-12 13:49:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/998283002/1
5 years, 9 months ago (2015-03-12 13:50:20 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-12 14:07:34 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-12 14:07:49 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/99f8d57f3c5d967bc3b10356b22d7ec7be55e89f
Cr-Commit-Position: refs/heads/master@{#27160}

Powered by Google App Engine
This is Rietveld 408576698