Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 998023002: Revert of Splitting of layers for correct intersections (Closed)

Created:
5 years, 9 months ago by gab
Modified:
5 years, 9 months ago
CC:
cc-bugs_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Splitting of layers for correct intersections (patchset #20 id:370001 of https://codereview.chromium.org/595593002/) Reason for revert: Appears to be adding new static initializers and is breaking Mac/Linux builders, e.g.: http://build.chromium.org/p/chromium/buildstatus?builder=Mac&number=34562 Original issue's description: > Splitting of layers for correct intersections > > Sorting 3d-sorted layers and rendering them in that order causes issues > when layers intersect. Instead place 3d-sorted layers in a bsp tree and > fragment any intersecting layers into non-rectangular quads. We can then > render the fragments in the correct sorted order regardless of > intersections. > > BUG=455918, 159225, 132122, 230833 > > Committed: https://crrev.com/7e2af77dcd3b5df086be3421fad40b719779381c > Cr-Commit-Position: refs/heads/master@{#320096} TBR=enne@chromium.org,danakj@chromium.org,eroman@chromium.org,thakis@chromium.org,awoloszyn@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=455918, 159225, 132122, 230833 Committed: https://crrev.com/f0d5e0d31ba3659eb782d87baf95539ccd2b6d36 Cr-Commit-Position: refs/heads/master@{#320122}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1737 lines, -1682 lines) Patch
M cc/BUILD.gn View 4 chunks +3 lines, -4 lines 0 comments Download
M cc/cc.gyp View 3 chunks +2 lines, -4 lines 0 comments Download
M cc/cc_tests.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M cc/output/bsp_tree.cc View 1 chunk +2 lines, -1 line 0 comments Download
M cc/output/bsp_walk_action.h View 1 chunk +0 lines, -16 lines 0 comments Download
M cc/output/bsp_walk_action.cc View 1 chunk +2 lines, -24 lines 0 comments Download
M cc/output/direct_renderer.h View 4 chunks +3 lines, -21 lines 0 comments Download
M cc/output/direct_renderer.cc View 4 chunks +17 lines, -92 lines 0 comments Download
D cc/output/dynamic_geometry_binding.h View 1 chunk +0 lines, -30 lines 0 comments Download
D cc/output/dynamic_geometry_binding.cc View 1 chunk +0 lines, -67 lines 0 comments Download
M cc/output/geometry_binding.h View 1 chunk +20 lines, -42 lines 0 comments Download
M cc/output/geometry_binding.cc View 2 chunks +72 lines, -55 lines 0 comments Download
M cc/output/gl_renderer.h View 10 chunks +23 lines, -55 lines 0 comments Download
M cc/output/gl_renderer.cc View 41 chunks +83 lines, -432 lines 0 comments Download
M cc/output/overlay_unittest.cc View 4 chunks +4 lines, -7 lines 0 comments Download
M cc/output/renderer_pixeltest.cc View 13 chunks +254 lines, -558 lines 0 comments Download
M cc/output/software_renderer.h View 1 chunk +1 line, -4 lines 0 comments Download
M cc/output/software_renderer.cc View 4 chunks +2 lines, -34 lines 0 comments Download
D cc/output/static_geometry_binding.h View 1 chunk +0 lines, -33 lines 0 comments Download
D cc/output/static_geometry_binding.cc View 1 chunk +0 lines, -72 lines 0 comments Download
M cc/quads/draw_polygon.h View 3 chunks +4 lines, -5 lines 0 comments Download
M cc/quads/draw_polygon.cc View 9 chunks +10 lines, -23 lines 0 comments Download
M cc/quads/draw_quad.cc View 1 chunk +3 lines, -1 line 0 comments Download
M cc/resources/layer_quad.h View 3 chunks +1 line, -4 lines 0 comments Download
M cc/resources/layer_quad.cc View 3 chunks +14 lines, -57 lines 0 comments Download
M cc/test/data/anti_aliasing.png View Binary file 0 comments Download
M cc/test/data/background_filter_blur_off_axis.png View Binary file 0 comments Download
D cc/test/data/intersecting_blue_green.png View Binary file 0 comments Download
D cc/test/data/intersecting_blue_green_squares.png View Binary file 0 comments Download
D cc/test/data/intersecting_blue_green_squares_video.png View Binary file 0 comments Download
A cc/trees/layer_sorter.h View 1 chunk +97 lines, -0 lines 0 comments Download
A cc/trees/layer_sorter.cc View 1 chunk +470 lines, -0 lines 0 comments Download
A cc/trees/layer_sorter_unittest.cc View 1 chunk +329 lines, -0 lines 0 comments Download
M cc/trees/layer_tree_host_common.cc View 6 chunks +31 lines, -0 lines 0 comments Download
M cc/trees/layer_tree_host_common_perftest.cc View 4 chunks +52 lines, -14 lines 0 comments Download
M cc/trees/layer_tree_host_common_unittest.cc View 2 chunks +176 lines, -0 lines 0 comments Download
M cc/trees/layer_tree_host_pixeltest_filters.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/trees/layer_tree_impl_unittest.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M cc/trees/occlusion_tracker.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/occlusion_tracker_unittest.cc View 1 chunk +50 lines, -0 lines 0 comments Download
M ui/gfx/geometry/quad_f.h View 2 chunks +0 lines, -13 lines 0 comments Download
M ui/gfx/skia_util.h View 2 chunks +0 lines, -3 lines 0 comments Download
M ui/gfx/skia_util.cc View 2 chunks +0 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
gab
Created Revert of Splitting of layers for correct intersections
5 years, 9 months ago (2015-03-11 19:32:23 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/998023002/1
5 years, 9 months ago (2015-03-11 19:38:52 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-11 19:46:32 UTC) #3
commit-bot: I haz the power
5 years, 9 months ago (2015-03-11 19:47:30 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f0d5e0d31ba3659eb782d87baf95539ccd2b6d36
Cr-Commit-Position: refs/heads/master@{#320122}

Powered by Google App Engine
This is Rietveld 408576698