Add AnimationTimingProperties dictionary

Add AnimationTimingProperties dictionary

Use in various places:

- As the base of the ComputedTimingProperties dictionary.

- As one possible argument value to the Animation() constructor's third
  parameter.

- As one possible argument value to Element.animate()'s second parameter.

Also remove the custom bindings implementation of Element.animate().

BUG=321462
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190837

[Jens Widell, 2015-02-23 12:06:59]

jl@opera.com changed reviewers:
+ dstockwell@chromium.org, haraken@chromium.org

[Jens Widell, 2015-02-23 12:07:00]

PTAL

https://codereview.chromium.org/947923002/diff/1/Source/bindings/core/v8/ToV8.h
File Source/bindings/core/v8/ToV8.h (right):

https://codereview.chromium.org/947923002/diff/1/Source/bindings/core/v8/ToV8...
Source/bindings/core/v8/ToV8.h:190: ASSERT_NOT_REACHED();
Adding this was necessary due to the use of sequence<Dictionary> in a union
type, since this unconditionally generated code to convert a union value to a V8
value. The union is used as a method argument only, so the conversion code is
not actually used.

Properly converting a Dictionary to a V8 value is of course possible, but we
should probably do it by cloning the V8 object wrapped by the Dictionary rather
than by just returning it. Or maybe not. Hopefully we never actually need this.

Do we think it's okay to add this implementation, just to make the generated
conversion code compile?

[haraken, 2015-02-23 13:41:17]

This is a nice clean-up! LGTM.

https://codereview.chromium.org/947923002/diff/1/Source/bindings/core/v8/ToV8.h
File Source/bindings/core/v8/ToV8.h (right):

https://codereview.chromium.org/947923002/diff/1/Source/bindings/core/v8/ToV8...
Source/bindings/core/v8/ToV8.h:190: ASSERT_NOT_REACHED();
On 2015/02/23 12:07:00, Jens Widell wrote:
> Adding this was necessary due to the use of sequence<Dictionary> in a union
> type, since this unconditionally generated code to convert a union value to a
V8
> value. The union is used as a method argument only, so the conversion code is
> not actually used.
> 
> Properly converting a Dictionary to a V8 value is of course possible, but we
> should probably do it by cloning the V8 object wrapped by the Dictionary
rather
> than by just returning it. Or maybe not. Hopefully we never actually need
this.
> 
> Do we think it's okay to add this implementation, just to make the generated
> conversion code compile?

I'm fine in this CL, but it would be great if we could remove it in a follow-up
:)

[dstockwell, 2015-02-24 03:22:03]

lgtm

https://codereview.chromium.org/947923002/diff/1/Source/core/animation/Animat...
File Source/core/animation/Animation.idl (right):

https://codereview.chromium.org/947923002/diff/1/Source/core/animation/Animat...
Source/core/animation/Animation.idl:34: // FIXME: the third argument should be
"optional (unrestricted double or AnimationTimingProperties) timing".
What's still necessary in order to fix this?

[haraken, 2015-02-24 06:11:09]

https://codereview.chromium.org/947923002/diff/1/Source/core/animation/Animat...
File Source/core/animation/Animation.idl (right):

https://codereview.chromium.org/947923002/diff/1/Source/core/animation/Animat...
Source/core/animation/Animation.idl:34: // FIXME: the third argument should be
"optional (unrestricted double or AnimationTimingProperties) timing".
On 2015/02/24 03:22:03, dstockwell wrote:
> What's still necessary in order to fix this?

We don't yet support a dictionary in a union type.

[Jens Widell, 2015-02-25 15:09:23]

The CQ bit was checked by jl@opera.com

[commit-bot: I haz the power, 2015-02-25 15:09:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/947923002/1

[commit-bot: I haz the power, 2015-02-25 15:26:03]

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190837

[dstockwell, 2015-05-15 00:26:36]

We accidentally removed use counting of Element.animate in this patch :(

I'm going to add it back in the idl.