Add AnimationTimingProperties dictionary

Source/bindings/core/v8/ToV8.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef ToV8_h
 #define ToV8_h
 
 #include "bindings/core/v8/DOMDataStore.h"
 #include "bindings/core/v8/ScriptValue.h"
 #include "bindings/core/v8/ScriptWrappable.h"
 #include "bindings/core/v8/V8Binding.h"
 #include "platform/heap/Handle.h"
 #include "wtf/Forward.h"
 #include <v8.h>
 
 namespace blink {
 
 class DOMWindow;
+class Dictionary;
 class EventTarget;
 class WorkerGlobalScope;
 
 // ScriptWrappable
 
 inline v8::Handle<v8::Value> toV8(ScriptWrappable* impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate)
 {
     if (UNLIKELY(!impl))
         return v8::Null(isolate);
     v8::Handle<v8::Value> wrapper = DOMDataStore::getWrapper(impl, isolate);
@@ skipping 146 matching lines @@
     return v8::Undefined(isolate);
 }
 
 // ScriptValue
 
 inline v8::Handle<v8::Value> toV8(const ScriptValue& value, v8::Handle<v8::Object> creationContext, v8::Isolate*)
 {
     return value.v8Value();
 }
 
+// Dictionary
+
+inline v8::Handle<v8::Value> toV8(const Dictionary& value, v8::Handle<v8::Object> creationContext, v8::Isolate*)
+{
+    ASSERT_NOT_REACHED();

[Jens Widell, 2015/02/23 12:07:00]

Adding this was necessary due to the use of sequence<Dictionary> in a union
type, since this unconditionally generated code to convert a union value to a V8
value. The union is used as a method argument only, so the conversion code is
not actually used.

Properly converting a Dictionary to a V8 value is of course possible, but we
should probably do it by cloning the V8 object wrapped by the Dictionary rather
than by just returning it. Or maybe not. Hopefully we never actually need this.

Do we think it's okay to add this implementation, just to make the generated
conversion code compile?

[haraken, 2015/02/23 13:41:17]

I'm fine in this CL, but it would be great if we could remove it in a follow-up
:)

+    return v8::Handle<v8::Value>();
+}
+
 // Array
 
 template<typename Sequence>
 inline v8::Handle<v8::Value> toV8SequenceInternal(const Sequence& sequence, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate)
 {
     v8::Local<v8::Array> array = v8::Array::New(isolate, sequence.size());
     uint32_t index = 0;
     typename Sequence::const_iterator end = sequence.end();
     for (typename Sequence::const_iterator iter = sequence.begin(); iter != end; ++iter)
         array->Set(v8::Integer::New(isolate, index++), toV8(*iter, creationContext, isolate));
     return array;
 }
 
 template<typename T, size_t inlineCapacity>
 inline v8::Handle<v8::Value> toV8(const Vector<T, inlineCapacity>& value, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate)
 {
     return toV8SequenceInternal(value, creationContext, isolate);
 }
 
 template<typename T, size_t inlineCapacity>
 inline v8::Handle<v8::Value> toV8(const HeapVector<T, inlineCapacity>& value, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate)
 {
     return toV8SequenceInternal(value, creationContext, isolate);
 }
 
 } // namespace blink
 
 #endif // ToV8_h