Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Unified Diff: Source/core/animation/Animation.idl

Issue 947923002: Add AnimationTimingProperties dictionary (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/animation/Animation.idl
diff --git a/Source/core/animation/Animation.idl b/Source/core/animation/Animation.idl
index 02b98bf8234570c35b31e85820a75219fe3f3fa4..a9d194bcd40d14a6c578a577fdf635f4093bddf4 100644
--- a/Source/core/animation/Animation.idl
+++ b/Source/core/animation/Animation.idl
@@ -31,10 +31,9 @@
// http://dev.w3.org/fxtf/web-animations/#idl-def-Animation
[
- // FIXME: should be optional union type http://crbug.com/240176
- Constructor(Element? target, sequence<Dictionary> keyframes),
- Constructor(Element? target, sequence<Dictionary> keyframes, double timingInput),
- Constructor(Element? target, sequence<Dictionary> keyframes, Dictionary timingInput),
+ // FIXME: the third argument should be "optional (unrestricted double or AnimationTimingProperties) timing".
dstockwell 2015/02/24 03:22:03 What's still necessary in order to fix this?
haraken 2015/02/24 06:11:09 We don't yet support a dictionary in a union type.
+ Constructor(Element? target, sequence<Dictionary> keyframes, optional unrestricted double timing),
+ Constructor(Element? target, sequence<Dictionary> keyframes, AnimationTimingProperties timing),
RaisesException=Constructor,
RuntimeEnabled=WebAnimationsAPI,
] interface Animation : AnimationNode {

Powered by Google App Engine
This is Rietveld 408576698