Add AnimationTimingProperties dictionary

Source/core/animation/TimingInputTest.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "config.h"
 #include "core/animation/TimingInput.h"
 
-#include "bindings/core/v8/Dictionary.h"
+#include "bindings/core/v8/V8AnimationTimingProperties.h"
 #include "core/animation/AnimationNodeTiming.h"
 #include "core/animation/AnimationTestHelper.h"
 #include <gtest/gtest.h>
 #include <v8.h>
 
 namespace blink {
 
 class AnimationTimingInputTest : public ::testing::Test {
 protected:
     AnimationTimingInputTest()
         : m_isolate(v8::Isolate::GetCurrent())
         , m_scope(m_isolate)
     {
     }
 
     Timing applyTimingInputNumber(String timingProperty, double timingPropertyValue)
     {
         v8::Handle<v8::Object> timingInput = v8::Object::New(m_isolate);
         setV8ObjectPropertyAsNumber(timingInput, timingProperty, timingPropertyValue);
-        Dictionary timingInputDictionary = Dictionary(v8::Handle<v8::Value>::Cast(timingInput), m_isolate, exceptionState);
+        AnimationTimingProperties timingInputDictionary;
+        V8AnimationTimingProperties::toImpl(m_isolate, timingInput, timingInputDictionary, exceptionState);
         return TimingInput::convert(timingInputDictionary);
     }
 
     Timing applyTimingInputString(String timingProperty, String timingPropertyValue)
     {
         v8::Handle<v8::Object> timingInput = v8::Object::New(m_isolate);
         setV8ObjectPropertyAsString(timingInput, timingProperty, timingPropertyValue);
-        Dictionary timingInputDictionary = Dictionary(v8::Handle<v8::Value>::Cast(timingInput), m_isolate, exceptionState);
+        AnimationTimingProperties timingInputDictionary;
+        V8AnimationTimingProperties::toImpl(m_isolate, timingInput, timingInputDictionary, exceptionState);
         return TimingInput::convert(timingInputDictionary);
     }
 
     v8::Isolate* m_isolate;
     TrackExceptionState exceptionState;
 
 private:
     V8TestingScope m_scope;
 };
 
@@ skipping 50 matching lines @@
 
     EXPECT_EQ(0, applyTimingInputString("iterations", "-Infinity").iterationCount);
     EXPECT_EQ(1, applyTimingInputString("iterations", "NaN").iterationCount);
     EXPECT_EQ(1, applyTimingInputString("iterations", "rubbish").iterationCount);
 }
 
 TEST_F(AnimationTimingInputTest, TimingInputIterationDuration)
 {
     EXPECT_EQ(1.1, applyTimingInputNumber("duration", 1100).iterationDuration);
     EXPECT_TRUE(std::isnan(applyTimingInputNumber("duration", -1000).iterationDuration));
-    EXPECT_EQ(1, applyTimingInputString("duration", "1000").iterationDuration);
+    EXPECT_TRUE(std::isnan(applyTimingInputString("duration", "1000").iterationDuration));
 
-    Timing timing = applyTimingInputString("duration", "Infinity");
+    Timing timing = applyTimingInputNumber("duration", std::numeric_limits<double>::infinity());
     EXPECT_TRUE(std::isinf(timing.iterationDuration));
     EXPECT_GT(timing.iterationDuration, 0);
 
     EXPECT_TRUE(std::isnan(applyTimingInputString("duration", "-Infinity").iterationDuration));
     EXPECT_TRUE(std::isnan(applyTimingInputString("duration", "NaN").iterationDuration));
     EXPECT_TRUE(std::isnan(applyTimingInputString("duration", "auto").iterationDuration));
     EXPECT_TRUE(std::isnan(applyTimingInputString("duration", "rubbish").iterationDuration));
 }
 
 TEST_F(AnimationTimingInputTest, TimingInputPlaybackRate)
@@ skipping 37 matching lines @@
     EXPECT_EQ(*defaultTimingFunction, *applyTimingInputString("easing", "steps(5.6, end)").timingFunction);
     EXPECT_EQ(*defaultTimingFunction, *applyTimingInputString("easing", "cubic-bezier(2, 2, 0.3, 0.3)").timingFunction);
     EXPECT_EQ(*defaultTimingFunction, *applyTimingInputString("easing", "rubbish").timingFunction);
     EXPECT_EQ(*defaultTimingFunction, *applyTimingInputNumber("easing", 2).timingFunction);
     EXPECT_EQ(*defaultTimingFunction, *applyTimingInputString("easing", "initial").timingFunction);
 }
 
 TEST_F(AnimationTimingInputTest, TimingInputEmpty)
 {
     Timing controlTiming;
-
-    v8::Handle<v8::Object> timingInput = v8::Object::New(m_isolate);
-    Dictionary timingInputDictionary = Dictionary(v8::Handle<v8::Value>::Cast(timingInput), m_isolate, exceptionState);
-    Timing updatedTiming = TimingInput::convert(timingInputDictionary);
+    Timing updatedTiming = TimingInput::convert(AnimationTimingProperties());
 
     EXPECT_EQ(controlTiming.startDelay, updatedTiming.startDelay);
     EXPECT_EQ(controlTiming.fillMode, updatedTiming.fillMode);
     EXPECT_EQ(controlTiming.iterationStart, updatedTiming.iterationStart);
     EXPECT_EQ(controlTiming.iterationCount, updatedTiming.iterationCount);
     EXPECT_TRUE(std::isnan(updatedTiming.iterationDuration));
     EXPECT_EQ(controlTiming.playbackRate, updatedTiming.playbackRate);
     EXPECT_EQ(controlTiming.direction, updatedTiming.direction);
     EXPECT_EQ(*controlTiming.timingFunction, *updatedTiming.timingFunction);
 }
 
 } // namespace blink