Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Unified Diff: Source/core/animation/ElementAnimation.idl

Issue 947923002: Add AnimationTimingProperties dictionary (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/animation/ElementAnimation.idl
diff --git a/Source/core/animation/ElementAnimation.idl b/Source/core/animation/ElementAnimation.idl
index ccfbca7ee254095df084a9a1cca82d3dfe31201d..9d774f6abd3d543652abd53134540fd7b4020252 100644
--- a/Source/core/animation/ElementAnimation.idl
+++ b/Source/core/animation/ElementAnimation.idl
@@ -33,8 +33,9 @@
// http://dev.w3.org/fxtf/web-animations/#idl-def-Animatable
partial interface Element {
- // FIXME: needs support for union types http://crbug.com/240176
- // AnimationPlayer animate((AnimationEffect or sequence<Dictionary>)? effect, optional (double or Dictionary) timing);
- [Custom, RaisesException] AnimationPlayer animate(object effect, optional object timing);
+ // FIXME: Union types with dictionary type members doesn't work (yet).
+ // AnimationPlayer animate((AnimationEffect or sequence<Dictionary>)? effect, optional (double or AnimationTimingProperties) timing);
+ [RaisesException] AnimationPlayer animate((AnimationEffect or sequence<Dictionary>)? effect, optional double timing);
+ [RaisesException] AnimationPlayer animate((AnimationEffect or sequence<Dictionary>)? effect, AnimationTimingProperties timing);
[RuntimeEnabled=WebAnimationsAPI] sequence<AnimationPlayer> getAnimationPlayers();
};

Powered by Google App Engine
This is Rietveld 408576698