Step two of optionally sending messages to/from message ports as base::Value.

Step two of optionally sending messages to/from message ports as base::Value.

This CL changes every place a MessagePort is transferred between process to
properly propagate the send_messages_as_values flag, as well as makes it
possible for NavigatorConnectContext to set this flag when setting up a
new connection.

This is part of a series of changes:
[1/5] Blink side changes in https://codereview.chromium.org/924983002/ that expose a needed v8 context
[2/5] https://codereview.chromium.org/921013002/ allow MessagePort to send messages as values
[3/5] This CL
[4/5] https://codereview.chromium.org/938403005/ which uses this for navigator.connect services and adds infrastructure for layout tests
[5/5] https://codereview.chromium.org/940423004/ adds layout tests to blink to test these new features

BUG=426458
Committed: https://crrev.com/5b679c9db20587c78e9bf7c076edd7584413cc3b
Cr-Commit-Position: refs/heads/master@{#318578}

[Marijn Kruisselbrink, 2015-02-20 23:18:49]

mek@chromium.org changed reviewers:
+ scheib@chromium.org

[Marijn Kruisselbrink, 2015-02-20 23:18:50]

Unfortunately a rather large patch, although most of it is a pretty mechanical
replacement of std::vector<int> with std::vector<TransferredMessagePort>.

Maybe hold of with reviewing until jochen is back from vacation and has had a
chance to agree (or disagree) with the required blink change.

[scheib, 2015-02-26 21:57:05]

lgtm

[Marijn Kruisselbrink, 2015-02-27 21:30:54]

mek@chromium.org changed reviewers:
+ avi@chromium.org, sgurun@chromium.org

[Marijn Kruisselbrink, 2015-02-27 21:30:55]

+avi for content OWNERS
+sgurun for android_webview OWNERS

[Avi (use Gerrit), 2015-02-27 21:37:55]

lgtm

stampity stamp

https://codereview.chromium.org/944443003/diff/80001/content/browser/message_...
File content/browser/message_port_service.cc (right):

https://codereview.chromium.org/944443003/diff/80001/content/browser/message_...
content/browser/message_port_service.cc:229: for (const TransferredMessagePort&
sent_port : message.second)
const auto&? (you do that on line 178 above)

https://codereview.chromium.org/944443003/diff/80001/content/browser/message_...
content/browser/message_port_service.cc:270: for (const TransferredMessagePort&
sent_port : message.second)
const auto&?

https://codereview.chromium.org/944443003/diff/80001/content/browser/message_...
content/browser/message_port_service.cc:290: for (const TransferredMessagePort&
sent_port : message.second)
ditto

https://codereview.chromium.org/944443003/diff/80001/content/browser/navigato...
File
content/browser/navigator_connect/navigator_connect_service_worker_service_factory.cc
(right):

https://codereview.chromium.org/944443003/diff/80001/content/browser/navigato...
content/browser/navigator_connect/navigator_connect_service_worker_service_factory.cc:83:
for (const TransferredMessagePort& port : sent_message_ports)
const auto&?

[Marijn Kruisselbrink, 2015-02-27 23:20:18]

https://codereview.chromium.org/944443003/diff/80001/content/browser/message_...
File content/browser/message_port_service.cc (right):

https://codereview.chromium.org/944443003/diff/80001/content/browser/message_...
content/browser/message_port_service.cc:229: for (const TransferredMessagePort&
sent_port : message.second)
On 2015/02/27 21:37:55, Avi wrote:
> const auto&? (you do that on line 178 above)

I think my reasoning was that on line 178 it's fairly clear what auto refers to,
since it's iterating over a parameter to the method, while in these other three
cases it's pretty much impossible to figure out what "auto" means without
looking at message_port_service.h. Especially since it's already hard to figure
out what |message.second| actually is, I think that using auto here would make
it even harder to figure out what the code does.

https://codereview.chromium.org/944443003/diff/80001/content/browser/navigato...
File
content/browser/navigator_connect/navigator_connect_service_worker_service_factory.cc
(right):

https://codereview.chromium.org/944443003/diff/80001/content/browser/navigato...
content/browser/navigator_connect/navigator_connect_service_worker_service_factory.cc:83:
for (const TransferredMessagePort& port : sent_message_ports)
On 2015/02/27 21:37:55, Avi wrote:
> const auto&?

Done.

[Marijn Kruisselbrink, 2015-02-27 23:21:58]

mek@chromium.org changed reviewers:
+ tsepez@chromium.org

[Marijn Kruisselbrink, 2015-02-27 23:21:59]

+tsepez for IPC OWNERS

[Tom Sepez, 2015-02-27 23:27:15]

Messages LGTM.

[sgurun-gerrit only, 2015-02-28 00:56:40]

On 2015/02/27 23:27:15, Tom Sepez wrote:
> Messages LGTM.

lgtm

[Marijn Kruisselbrink, 2015-02-28 00:57:42]

The CQ bit was checked by mek@chromium.org

[Marijn Kruisselbrink, 2015-02-28 00:57:43]

The patchset sent to the CQ was uploaded after l-g-t-m from scheib@chromium.org,
avi@chromium.org
Link to the patchset: https://codereview.chromium.org/944443003/#ps100001
(title: "use auto where it makes sense")

[commit-bot: I haz the power, 2015-02-28 01:04:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/944443003/100001

[commit-bot: I haz the power, 2015-02-28 01:59:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-28 01:59:53]

Try jobs failed on following builders:
  android_aosp on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/bu...)
  linux_chromium_gn_dbg on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Marijn Kruisselbrink, 2015-02-28 02:00:40]

The CQ bit was checked by mek@chromium.org

[commit-bot: I haz the power, 2015-02-28 02:01:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/944443003/100001

[commit-bot: I haz the power, 2015-02-28 02:38:14]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2015-02-28 02:39:09]

Patchset 6 (id:??) landed as
https://crrev.com/5b679c9db20587c78e9bf7c076edd7584413cc3b
Cr-Commit-Position: refs/heads/master@{#318578}