Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(826)

Unified Diff: content/browser/shared_worker/shared_worker_service_impl_unittest.cc

Issue 944443003: Step two of optionally sending messages to/from message ports as base::Value. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@n-c-message-as-values-take2
Patch Set: use auto where it makes sense Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/shared_worker/shared_worker_service_impl_unittest.cc
diff --git a/content/browser/shared_worker/shared_worker_service_impl_unittest.cc b/content/browser/shared_worker/shared_worker_service_impl_unittest.cc
index 6407bbfca2d974bcb5a79f5c88fc102e27f8c2dc..7ca585ea2cd53168ad53d61d7a917d1faeec7dc4 100644
--- a/content/browser/shared_worker/shared_worker_service_impl_unittest.cc
+++ b/content/browser/shared_worker/shared_worker_service_impl_unittest.cc
@@ -285,11 +285,11 @@ class MockSharedWorkerConnector {
new MessagePortHostMsg_QueueMessages(remote_port_id_)));
}
void SendPostMessage(std::string data) {
- const std::vector<int> empty_ids;
+ const std::vector<TransferredMessagePort> empty_ports;
EXPECT_TRUE(
renderer_host_->OnMessageReceived(new MessagePortHostMsg_PostMessage(
local_port_id_,
- MessagePortMessage(base::ASCIIToUTF16(data)), empty_ids)));
+ MessagePortMessage(base::ASCIIToUTF16(data)), empty_ports)));
}
void SendConnect() {
EXPECT_TRUE(
@@ -467,11 +467,11 @@ TEST_F(SharedWorkerServiceImplTest, BasicTest) {
// When SharedWorker side sends MessagePortHostMsg_PostMessage,
// SharedWorkerConnector side shuold receive MessagePortMsg_Message.
- const std::vector<int> empty_ids;
+ const std::vector<TransferredMessagePort> empty_ports;
EXPECT_TRUE(
renderer_host->OnMessageReceived(new MessagePortHostMsg_PostMessage(
connector->remote_port_id(),
- MessagePortMessage(base::ASCIIToUTF16("test2")), empty_ids)));
+ MessagePortMessage(base::ASCIIToUTF16("test2")), empty_ports)));
EXPECT_EQ(1U, renderer_host->QueuedMessageCount());
CheckMessagePortMsgMessage(
renderer_host.get(), connector->local_port_route_id(), "test2");
@@ -564,11 +564,11 @@ TEST_F(SharedWorkerServiceImplTest, TwoRendererTest) {
// When SharedWorker side sends MessagePortHostMsg_PostMessage,
// SharedWorkerConnector side shuold receive MessagePortMsg_Message.
- const std::vector<int> empty_ids;
+ const std::vector<TransferredMessagePort> empty_ports;
EXPECT_TRUE(
renderer_host0->OnMessageReceived(new MessagePortHostMsg_PostMessage(
connector0->remote_port_id(),
- MessagePortMessage(base::ASCIIToUTF16("test2")), empty_ids)));
+ MessagePortMessage(base::ASCIIToUTF16("test2")), empty_ports)));
EXPECT_EQ(1U, renderer_host0->QueuedMessageCount());
CheckMessagePortMsgMessage(
renderer_host0.get(), connector0->local_port_route_id(), "test2");
@@ -647,7 +647,7 @@ TEST_F(SharedWorkerServiceImplTest, TwoRendererTest) {
EXPECT_TRUE(
renderer_host0->OnMessageReceived(new MessagePortHostMsg_PostMessage(
connector1->remote_port_id(),
- MessagePortMessage(base::ASCIIToUTF16("test4")), empty_ids)));
+ MessagePortMessage(base::ASCIIToUTF16("test4")), empty_ports)));
EXPECT_EQ(1U, renderer_host1->QueuedMessageCount());
CheckMessagePortMsgMessage(
renderer_host1.get(), connector1->local_port_route_id(), "test4");
« no previous file with comments | « content/browser/service_worker/service_worker_version.cc ('k') | content/browser/web_contents/web_contents_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698