content/child/navigator_connect/navigator_connect_provider.cc - Issue 944443003: Step two of optionally sending messages to/from message ports as base::Value.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/child/navigator_connect/navigator_connect_provider.cc

Issue 944443003: Step two of optionally sending messages to/from message ports as base::Value. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@n-c-message-as-values-take2

Patch Set: use auto where it makes sense Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/child/navigator_connect/navigator_connect_provider.h ('k') | content/child/service_worker/service_worker_dispatcher.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/child/navigator_connect/navigator_connect_provider.cc

diff --git a/content/child/navigator_connect/navigator_connect_provider.cc b/content/child/navigator_connect/navigator_connect_provider.cc

index 415b7a3457a408a5c51745565d2a3a12ec8d2d37..78c3fdad7fd6a81886d1d7b5baa83ed9d288e159 100644

--- a/content/child/navigator_connect/navigator_connect_provider.cc

+++ b/content/child/navigator_connect/navigator_connect_provider.cc

@@ -77,18 +77,19 @@ NavigatorConnectProvider* NavigatorConnectProvider::ThreadSpecificInstance(

return provider;

}

-void NavigatorConnectProvider::OnConnectResult(int thread_id,

- int request_id,

- int message_port_id,

- int message_port_route_id,

- bool allow_connect) {

+void NavigatorConnectProvider::OnConnectResult(

+ int thread_id,

+ int request_id,

+ const TransferredMessagePort& message_port,

+ int message_port_route_id,

+ bool allow_connect) {

blink::WebNavigatorConnectPortCallbacks* callbacks =

requests_.Lookup(request_id);

DCHECK(callbacks);

if (allow_connect) {

WebMessagePortChannelImpl* channel = new WebMessagePortChannelImpl(

- message_port_route_id, message_port_id, main_loop_);

+ message_port_route_id, message_port, main_loop_);

callbacks->onSuccess(channel);

} else {

callbacks->onError();