Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Unified Diff: content/renderer/render_view_impl.cc

Issue 944443003: Step two of optionally sending messages to/from message ports as base::Value. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@n-c-message-as-values-take2
Patch Set: use auto where it makes sense Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_view_impl.cc
diff --git a/content/renderer/render_view_impl.cc b/content/renderer/render_view_impl.cc
index 19fb20a6b962e16222a7551d80823347f7ba5a55..6519f3789292af260f8da4c1d0029d625661ef73 100644
--- a/content/renderer/render_view_impl.cc
+++ b/content/renderer/render_view_impl.cc
@@ -2785,16 +2785,10 @@ void RenderViewImpl::OnPostMessageEvent(
}
// If the message contained MessagePorts, create the corresponding endpoints.
- DCHECK_EQ(params.message_port_ids.size(), params.new_routing_ids.size());
- blink::WebMessagePortChannelArray channels(params.message_port_ids.size());
- for (size_t i = 0;
- i < params.message_port_ids.size() && i < params.new_routing_ids.size();
- ++i) {
- channels[i] =
- new WebMessagePortChannelImpl(params.new_routing_ids[i],
- params.message_port_ids[i],
- base::MessageLoopProxy::current().get());
- }
+ blink::WebMessagePortChannelArray channels =
+ WebMessagePortChannelImpl::CreatePorts(
+ params.message_ports, params.new_routing_ids,
+ base::MessageLoopProxy::current().get());
WebSerializedScriptValue serialized_script_value;
if (params.is_data_raw_string) {
« no previous file with comments | « content/renderer/render_frame_proxy.cc ('k') | content/renderer/service_worker/service_worker_script_context.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698