Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 938403005: Make it possible for a navigator.connect service to receive messages as base::Value. (Closed)

Created:
5 years, 10 months ago by Marijn Kruisselbrink
Modified:
5 years, 9 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org, kinuko+watch, mkwst+moarreviews-shell_chromium.org, jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@n-c-message-as-values-pass-flag
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make it possible for a navigator.connect service to receive messages as base::Value. Also adds a simple service to allow layout tests to test all this. This is part of a series of changes: [1/5] Blink side changes in https://codereview.chromium.org/924983002/ that expose a needed v8 context [2/5] https://codereview.chromium.org/921013002/ allow MessagePort to send messages as values [3/5] https://codereview.chromium.org/944443003/ which causes the send_messages_as_values flag to be propagated [4/5] This CL [5/5] https://codereview.chromium.org/940423004/ adds layout tests to blink to test these new features BUG=426458 Committed: https://crrev.com/c9182205440405d83beda62b7a75210a26082b11 Cr-Commit-Position: refs/heads/master@{#318903}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Patch Set 4 : small improvements #

Total comments: 2

Patch Set 5 : rebase #

Patch Set 6 : mention bug #

Messages

Total messages: 15 (5 generated)
Marijn Kruisselbrink
Maybe hold of with reviewing until jochen is back from vacation and has had a ...
5 years, 10 months ago (2015-02-20 23:19:37 UTC) #2
scheib
lgtm https://codereview.chromium.org/938403005/diff/60001/content/browser/navigator_connect/navigator_connect_service_worker_service_factory.cc File content/browser/navigator_connect/navigator_connect_service_worker_service_factory.cc (right): https://codereview.chromium.org/938403005/diff/60001/content/browser/navigator_connect/navigator_connect_service_worker_service_factory.cc#newcode193 content/browser/navigator_connect/navigator_connect_service_worker_service_factory.cc:193: // clean them up when a service worker ...
5 years, 10 months ago (2015-02-26 22:20:45 UTC) #3
Marijn Kruisselbrink
https://codereview.chromium.org/938403005/diff/60001/content/browser/navigator_connect/navigator_connect_service_worker_service_factory.cc File content/browser/navigator_connect/navigator_connect_service_worker_service_factory.cc (right): https://codereview.chromium.org/938403005/diff/60001/content/browser/navigator_connect/navigator_connect_service_worker_service_factory.cc#newcode193 content/browser/navigator_connect/navigator_connect_service_worker_service_factory.cc:193: // clean them up when a service worker registration ...
5 years, 9 months ago (2015-02-27 22:23:12 UTC) #4
Marijn Kruisselbrink
+pfeldman for content/shell OWNERS
5 years, 9 months ago (2015-02-27 22:23:41 UTC) #6
pfeldman
shell owner lgtm
5 years, 9 months ago (2015-03-02 16:54:19 UTC) #7
Marijn Kruisselbrink
+avi for content/public OWNERS
5 years, 9 months ago (2015-03-02 16:58:50 UTC) #9
Avi (use Gerrit)
On 2015/03/02 16:58:50, Marijn Kruisselbrink wrote: > +avi for content/public OWNERS content/public lgtm
5 years, 9 months ago (2015-03-03 17:02:50 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/938403005/100001
5 years, 9 months ago (2015-03-03 17:03:46 UTC) #13
commit-bot: I haz the power
Committed patchset #6 (id:100001)
5 years, 9 months ago (2015-03-03 17:56:19 UTC) #14
commit-bot: I haz the power
5 years, 9 months ago (2015-03-03 17:57:10 UTC) #15
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/c9182205440405d83beda62b7a75210a26082b11
Cr-Commit-Position: refs/heads/master@{#318903}

Powered by Google App Engine
This is Rietveld 408576698