Maybe hold of with reviewing until jochen is back from vacation and has had a ...
5 years, 10 months ago
(2015-02-20 23:19:37 UTC)
#2
Maybe hold of with reviewing until jochen is back from vacation and has had a
chance to agree (or disagree) with the required blink change.
scheib
lgtm https://codereview.chromium.org/938403005/diff/60001/content/browser/navigator_connect/navigator_connect_service_worker_service_factory.cc File content/browser/navigator_connect/navigator_connect_service_worker_service_factory.cc (right): https://codereview.chromium.org/938403005/diff/60001/content/browser/navigator_connect/navigator_connect_service_worker_service_factory.cc#newcode193 content/browser/navigator_connect/navigator_connect_service_worker_service_factory.cc:193: // clean them up when a service worker ...
5 years, 10 months ago
(2015-02-26 22:20:45 UTC)
#3
https://codereview.chromium.org/938403005/diff/60001/content/browser/navigator_connect/navigator_connect_service_worker_service_factory.cc File content/browser/navigator_connect/navigator_connect_service_worker_service_factory.cc (right): https://codereview.chromium.org/938403005/diff/60001/content/browser/navigator_connect/navigator_connect_service_worker_service_factory.cc#newcode193 content/browser/navigator_connect/navigator_connect_service_worker_service_factory.cc:193: // clean them up when a service worker registration ...
5 years, 9 months ago
(2015-02-27 22:23:12 UTC)
#4
Issue 938403005: Make it possible for a navigator.connect service to receive messages as base::Value.
(Closed)
Created 5 years, 10 months ago by Marijn Kruisselbrink
Modified 5 years, 9 months ago
Reviewers: scheib, pfeldman, Avi (use Gerrit)
Base URL: https://chromium.googlesource.com/chromium/src.git@n-c-message-as-values-pass-flag
Comments: 2