content/browser/service_worker/service_worker_dispatcher_host.cc - Issue 944443003: Step two of optionally sending messages to/from message ports as base::Value.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_dispatcher_host.cc

Issue 944443003: Step two of optionally sending messages to/from message ports as base::Value. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@n-c-message-as-values-take2

Patch Set: use auto where it makes sense Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/service_worker_dispatcher_host.h ('k') | content/browser/service_worker/service_worker_provider_host.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_dispatcher_host.cc

diff --git a/content/browser/service_worker/service_worker_dispatcher_host.cc b/content/browser/service_worker/service_worker_dispatcher_host.cc

index 6ffbfc5c9a869b086f2777336467e1a83e62b6ae..6f1d95f078618c9c207087699ef8b185bcc20c84 100644

--- a/content/browser/service_worker/service_worker_dispatcher_host.cc

+++ b/content/browser/service_worker/service_worker_dispatcher_host.cc

@@ -495,7 +495,7 @@ void ServiceWorkerDispatcherHost::OnGetRegistration(

void ServiceWorkerDispatcherHost::OnPostMessageToWorker(

int handle_id,

const base::string16& message,

- const std::vector<int>& sent_message_port_ids) {

+ const std::vector<TransferredMessagePort>& sent_message_ports) {

TRACE_EVENT0("ServiceWorker",

"ServiceWorkerDispatcherHost::OnPostMessageToWorker");

if (!GetContext())

@@ -508,7 +508,7 @@ void ServiceWorkerDispatcherHost::OnPostMessageToWorker(

}

handle->version()->DispatchMessageEvent(

- message, sent_message_port_ids,

+ message, sent_message_ports,

base::Bind(&ServiceWorkerUtils::NoOpStatusCallback));

}