Issue 943433002: querySelectorAll should return List<Element>

Issue 943433002: querySelectorAll should return List<Element> (Closed)

Created:
5 years, 10 months ago by abarth-chromium

Modified:
5 years, 10 months ago

Reviewers:
ojan, eseidel

CC:
mojo-reviews_chromium.org, ojan, esprehn, qsr+mojo_chromium.org, eseidel

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -26 lines)			Patch
M	sky/engine/core/dom/ContainerNode.h	View		2 chunks	+1 line, -2 lines	0 comments	Download
M	sky/engine/core/dom/ContainerNode.cpp	View	1	1 chunk	+6 lines, -4 lines	0 comments	Download
M	sky/engine/core/dom/ParentNode.idl	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sky/engine/core/dom/SelectorQuery.h	View		2 chunks	+1 line, -2 lines	0 comments	Download
M	sky/engine/core/dom/SelectorQuery.cpp	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	sky/engine/core/dom/StaticNodeList.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	sky/tests/framework/flights-app-pixels.sky	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sky/tests/lowlevel/bug-438036.sky	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sky/tests/lowlevel/query-selector.sky	View		3 chunks	+11 lines, -11 lines	0 comments	Download

Total messages: 5 (1 generated)

eseidel

lgtm I wish there was a way to make the compiler enforce that it always ...

5 years, 10 months ago (2015-02-19 15:58:39 UTC) #3

abarth-chromium

On 2015/02/19 at 15:58:39, eseidel wrote: > lgtm > > I wish there was a ...

5 years, 10 months ago (2015-02-19 17:37:34 UTC) #4

abarth-chromium

5 years, 10 months ago (2015-02-19 17:40:03 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
e59419b9fbe1634126577a65df250d8b25657155 (presubmit successful).