Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1431)

Unified Diff: sky/engine/core/dom/SelectorQuery.cpp

Issue 943433002: querySelectorAll should return List<Element> (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Named return value optimization Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/core/dom/SelectorQuery.h ('k') | sky/engine/core/dom/StaticNodeList.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/core/dom/SelectorQuery.cpp
diff --git a/sky/engine/core/dom/SelectorQuery.cpp b/sky/engine/core/dom/SelectorQuery.cpp
index 1658289e3f7c0dab43374ba266eaf34356bd9e32..5eefe9baf2f83fa74c17dcc2ab3a71444098efb6 100644
--- a/sky/engine/core/dom/SelectorQuery.cpp
+++ b/sky/engine/core/dom/SelectorQuery.cpp
@@ -52,14 +52,14 @@ bool SelectorQuery::matches(Element& element) const
return selectorMatches(element, element);
}
-PassRefPtr<StaticElementList> SelectorQuery::queryAll(ContainerNode& rootNode) const
+Vector<RefPtr<Element>> SelectorQuery::queryAll(ContainerNode& rootNode) const
{
- Vector<RefPtr<Element> > result;
+ Vector<RefPtr<Element>> result;
for (Element* element = ElementTraversal::firstWithin(rootNode); element; element = ElementTraversal::next(*element, &rootNode)) {
if (selectorMatches(rootNode, *element))
result.append(element);
}
- return StaticElementList::adopt(result);
+ return result;
}
PassRefPtr<Element> SelectorQuery::queryFirst(ContainerNode& rootNode) const
« no previous file with comments | « sky/engine/core/dom/SelectorQuery.h ('k') | sky/engine/core/dom/StaticNodeList.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698