sky/tests/lowlevel/bug-438036.sky - Issue 943433002: querySelectorAll should return List<Element>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/tests/lowlevel/bug-438036.sky

Issue 943433002: querySelectorAll should return List<Element> (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Named return value optimization Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/tests/lowlevel/bug-438036.sky

diff --git a/sky/tests/lowlevel/bug-438036.sky b/sky/tests/lowlevel/bug-438036.sky

index d18c7dd0d577ae1e5a40a4464958ef7f383ab658..a92954aa8c13c427fbb1afa6d75dde04d240ad69 100644

--- a/sky/tests/lowlevel/bug-438036.sky

+++ b/sky/tests/lowlevel/bug-438036.sky

@@ -24,7 +24,7 @@ void main() {

});

test("should grow height to 200px", () {

- var target = document.querySelectorAll('div').item(1);

+ var target = document.querySelectorAll('div')[1];

target.setAttribute("id", "high");

expect(window.getComputedStyle(target).getPropertyValue("height"),

« no previous file with comments | « sky/tests/framework/flights-app-pixels.sky ('k') | sky/tests/lowlevel/query-selector.sky » ('j') | no next file with comments »