sky/tests/framework/flights-app-pixels.sky - Issue 943433002: querySelectorAll should return List<Element>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/tests/framework/flights-app-pixels.sky

Issue 943433002: querySelectorAll should return List<Element> (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Named return value optimization Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/tests/framework/flights-app-pixels.sky

diff --git a/sky/tests/framework/flights-app-pixels.sky b/sky/tests/framework/flights-app-pixels.sky

index 1eec0ee7eded90c061168c1da104027b291d5a5e..73ea2b2e6782c0ff71179f04c6b22e21d4356b12 100644

--- a/sky/tests/framework/flights-app-pixels.sky

+++ b/sky/tests/framework/flights-app-pixels.sky

@@ -312,7 +312,7 @@

bool imagesLoaded() {

var images = window.document.querySelectorAll('img');

for (var i = 0; i < images.length; i++) {

- if (!images.item(i).complete)

+ if (!images[i].complete)

return false;

}

return true;

« no previous file with comments | « sky/engine/core/dom/StaticNodeList.h ('k') | sky/tests/lowlevel/bug-438036.sky » ('j') | no next file with comments »