Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Side by Side Diff: sky/tests/framework/flights-app-pixels.sky

Issue 943433002: querySelectorAll should return List<Element> (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Named return value optimization Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « sky/engine/core/dom/StaticNodeList.h ('k') | sky/tests/lowlevel/bug-438036.sky » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <app> 1 <app>
2 <import src="../resources/run-after-display.sky" /> 2 <import src="../resources/run-after-display.sky" />
3 <style> 3 <style>
4 * { box-sizing: border-box; } 4 * { box-sizing: border-box; }
5 5
6 t, span { 6 t, span {
7 display: inline; 7 display: inline;
8 } 8 }
9 9
10 app { 10 app {
(...skipping 294 matching lines...) Expand 10 before | Expand all | Expand 10 after
305 <script> 305 <script>
306 import "dart:sky"; 306 import "dart:sky";
307 import "dart:sky.internals" as internals; 307 import "dart:sky.internals" as internals;
308 import "dart:async"; 308 import "dart:async";
309 309
310 var app; 310 var app;
311 311
312 bool imagesLoaded() { 312 bool imagesLoaded() {
313 var images = window.document.querySelectorAll('img'); 313 var images = window.document.querySelectorAll('img');
314 for (var i = 0; i < images.length; i++) { 314 for (var i = 0; i < images.length; i++) {
315 if (!images.item(i).complete) 315 if (!images[i].complete)
316 return false; 316 return false;
317 } 317 }
318 return true; 318 return true;
319 } 319 }
320 320
321 void checkImagesLoaded() { 321 void checkImagesLoaded() {
322 if (!imagesLoaded()) { 322 if (!imagesLoaded()) {
323 new Timer(new Duration(seconds:10), checkImagesLoaded); 323 new Timer(new Duration(seconds:10), checkImagesLoaded);
324 return; 324 return;
325 } 325 }
326 runAfterDisplay(() { 326 runAfterDisplay(() {
327 internals.notifyTestComplete(""); 327 internals.notifyTestComplete("");
328 }); 328 });
329 } 329 }
330 void main() { 330 void main() {
331 window.addEventListener("load", (_) { 331 window.addEventListener("load", (_) {
332 var input = document.querySelector('.input-text'); 332 var input = document.querySelector('.input-text');
333 window.getSelection().selectAllChildren(input.firstChild); 333 window.getSelection().selectAllChildren(input.firstChild);
334 checkImagesLoaded(); 334 checkImagesLoaded();
335 }); 335 });
336 } 336 }
337 </script> 337 </script>
338 </app> 338 </app>
OLDNEW
« no previous file with comments | « sky/engine/core/dom/StaticNodeList.h ('k') | sky/tests/lowlevel/bug-438036.sky » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698