Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(704)

Unified Diff: sky/engine/core/dom/ContainerNode.cpp

Issue 943433002: querySelectorAll should return List<Element> (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Named return value optimization Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/core/dom/ContainerNode.h ('k') | sky/engine/core/dom/ParentNode.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/core/dom/ContainerNode.cpp
diff --git a/sky/engine/core/dom/ContainerNode.cpp b/sky/engine/core/dom/ContainerNode.cpp
index ccdf11e954111987f47e2cfbb133e5f84652afbc..a5e43800e11681275972f3f9380c01ef4dd95569 100644
--- a/sky/engine/core/dom/ContainerNode.cpp
+++ b/sky/engine/core/dom/ContainerNode.cpp
@@ -942,18 +942,20 @@ PassRefPtr<Element> ContainerNode::querySelector(const AtomicString& selectors,
return selectorQuery->queryFirst(*this);
}
-PassRefPtr<StaticElementList> ContainerNode::querySelectorAll(const AtomicString& selectors, ExceptionState& exceptionState)
+Vector<RefPtr<Element>> ContainerNode::querySelectorAll(const AtomicString& selectors, ExceptionState& exceptionState)
{
+ Vector<RefPtr<Element>> result;
if (selectors.isEmpty()) {
exceptionState.ThrowDOMException(SyntaxError, "The provided selector is empty.");
- return nullptr;
+ return result;
}
SelectorQuery* selectorQuery = document().selectorQueryCache().add(selectors, document(), exceptionState);
if (!selectorQuery)
- return nullptr;
+ return result;
- return selectorQuery->queryAll(*this);
+ result = selectorQuery->queryAll(*this);
+ return result;
}
void ContainerNode::updateTreeAfterInsertion(Node& child)
« no previous file with comments | « sky/engine/core/dom/ContainerNode.h ('k') | sky/engine/core/dom/ParentNode.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698