sky/engine/core/dom/SelectorQuery.h - Issue 943433002: querySelectorAll should return List<Element>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/core/dom/SelectorQuery.h

Issue 943433002: querySelectorAll should return List<Element> (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Named return value optimization Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/engine/core/dom/SelectorQuery.h

diff --git a/sky/engine/core/dom/SelectorQuery.h b/sky/engine/core/dom/SelectorQuery.h

index fea6f4fb84a8ed685cadf9abb694913583b1599b..4f38a64566c6727852bc86cfe8489c95a42b62df 100644

--- a/sky/engine/core/dom/SelectorQuery.h

+++ b/sky/engine/core/dom/SelectorQuery.h

@@ -41,7 +41,6 @@ class Document;

class Element;

class ExceptionState;

template <typename NodeType> class StaticNodeTypeList;

-typedef StaticNodeTypeList<Element> StaticElementList;

class SelectorQuery {

WTF_MAKE_NONCOPYABLE(SelectorQuery);

@@ -50,7 +49,7 @@ public:

static PassOwnPtr<SelectorQuery> adopt(CSSSelectorList&);

bool matches(Element&) const;

- PassRefPtr<StaticElementList> queryAll(ContainerNode& rootNode) const;

+ Vector<RefPtr<Element>> queryAll(ContainerNode& rootNode) const;

PassRefPtr<Element> queryFirst(ContainerNode& rootNode) const;

private:

explicit SelectorQuery(CSSSelectorList&);

« no previous file with comments | « sky/engine/core/dom/ParentNode.idl ('k') | sky/engine/core/dom/SelectorQuery.cpp » ('j') | no next file with comments »