Issue 938773002: Remove strict-virtual-specifiers option, since it's enabled everywhere.

Issue 938773002: Remove strict-virtual-specifiers option, since it's enabled everywhere. (Closed)

Created:
5 years, 10 months ago by dcheng

Modified:
5 years, 10 months ago

Reviewers:
dmichael (off chromium), hans, Nico

CC:
chromium-reviews, dmichael (off chromium)

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Remove strict-virtual-specifiers option, since it's enabled everywhere. BUG=417463 Committed: https://crrev.com/2e49dd268d8b846f5301fb1323e3aed15f36cf59 Cr-Commit-Position: refs/heads/master@{#316888}

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+43 lines, -41 lines)			Patch
M	tools/clang/plugins/FindBadConstructsAction.cpp	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	tools/clang/plugins/FindBadConstructsConsumer.cpp	View	3 chunks	+4 lines, -12 lines	0 comments	Download
M	tools/clang/plugins/Options.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	tools/clang/plugins/tests/base_refcounted.h	View	6 chunks	+10 lines, -10 lines	0 comments	Download
M	tools/clang/plugins/tests/base_refcounted.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/clang/plugins/tests/base_refcounted.txt	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	tools/clang/plugins/tests/overridden_methods.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	tools/clang/plugins/tests/overridden_methods.cpp	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	tools/clang/plugins/tests/overridden_methods.txt	View	3 chunks	+17 lines, -1 line	0 comments	Download
D	tools/clang/plugins/tests/virtual_base_method_also_final.flags	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	tools/clang/plugins/tests/virtual_bodies.cpp	View	1 chunk	+2 lines, -2 lines	0 comments	Download
D	tools/clang/plugins/tests/virtual_specifiers.flags	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	tools/clang/plugins/tests/weak_ptr_factory.flags	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 10 (3 generated)

dcheng

(I've also fixed weak_ptr_factory.flags so --run-tests passes) I also have https://codereview.chromium.org/935083003 -- I'm not sure ...

5 years, 10 months ago (2015-02-18 17:53:47 UTC) #2

dmichael (off chromium)

lgtm (sorry about missing the weak ptr factory flag)

5 years, 10 months ago (2015-02-18 18:00:54 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/938773002/1

5 years, 10 months ago (2015-02-18 19:34:43 UTC) #8

commit-bot: I haz the power

5 years, 10 months ago (2015-02-18 20:42:06 UTC) #10

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/2e49dd268d8b846f5301fb1323e3aed15f36cf59
Cr-Commit-Position: refs/heads/master@{#316888}