Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Unified Diff: tools/clang/plugins/tests/overridden_methods.cpp

Issue 938773002: Remove strict-virtual-specifiers option, since it's enabled everywhere. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/clang/plugins/tests/overridden_methods.h ('k') | tools/clang/plugins/tests/overridden_methods.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/clang/plugins/tests/overridden_methods.cpp
diff --git a/tools/clang/plugins/tests/overridden_methods.cpp b/tools/clang/plugins/tests/overridden_methods.cpp
index 398d6a427182edf32166951d0af0464edf50c1f5..8b0340c1f33ab1178da48d1168294d2d12733091 100644
--- a/tools/clang/plugins/tests/overridden_methods.cpp
+++ b/tools/clang/plugins/tests/overridden_methods.cpp
@@ -11,19 +11,19 @@ void DerivedClass::WebKitModifiedSomething() {}
class ImplementationInterimClass : public BaseClass {
public:
- // Should not warn about pure virtual methods.
+ // Should warn about pure virtual methods.
virtual void SomeMethod() = 0;
};
class ImplementationDerivedClass : public ImplementationInterimClass,
public webkit_glue::WebKitObserverImpl {
public:
- // Should not warn about destructors.
+ // Should warn about destructors.
virtual ~ImplementationDerivedClass() {}
// Should warn.
virtual void SomeMethod();
// Should not warn if marked as override.
- virtual void SomeOtherMethod() override;
+ void SomeOtherMethod() override;
// Should not warn for inline implementations in implementation files.
virtual void SomeInlineMethod() {}
// Should not warn if overriding a method whose origin is blink.
« no previous file with comments | « tools/clang/plugins/tests/overridden_methods.h ('k') | tools/clang/plugins/tests/overridden_methods.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698