Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Side by Side Diff: tools/clang/plugins/FindBadConstructsAction.cpp

Issue 938773002: Remove strict-virtual-specifiers option, since it's enabled everywhere. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | tools/clang/plugins/FindBadConstructsConsumer.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "FindBadConstructsAction.h" 5 #include "FindBadConstructsAction.h"
6 6
7 #include "clang/AST/ASTConsumer.h" 7 #include "clang/AST/ASTConsumer.h"
8 #include "clang/Frontend/FrontendPluginRegistry.h" 8 #include "clang/Frontend/FrontendPluginRegistry.h"
9 9
10 #include "FindBadConstructsConsumer.h" 10 #include "FindBadConstructsConsumer.h"
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
46 bool parsed = true; 46 bool parsed = true;
47 47
48 for (size_t i = 0; i < args.size() && parsed; ++i) { 48 for (size_t i = 0; i < args.size() && parsed; ++i) {
49 if (args[i] == "check-base-classes") { 49 if (args[i] == "check-base-classes") {
50 // TODO(rsleevi): Remove this once http://crbug.com/123295 is fixed. 50 // TODO(rsleevi): Remove this once http://crbug.com/123295 is fixed.
51 options_.check_base_classes = true; 51 options_.check_base_classes = true;
52 } else if (args[i] == "check-enum-last-value") { 52 } else if (args[i] == "check-enum-last-value") {
53 // TODO(tsepez): Enable this by default once http://crbug.com/356815 53 // TODO(tsepez): Enable this by default once http://crbug.com/356815
54 // and http://crbug.com/356816 are fixed. 54 // and http://crbug.com/356816 are fixed.
55 options_.check_enum_last_value = true; 55 options_.check_enum_last_value = true;
56 } else if (args[i] == "strict-virtual-specifiers") {
57 options_.strict_virtual_specifiers = true;
58 } else if (args[i] == "with-ast-visitor") { 56 } else if (args[i] == "with-ast-visitor") {
59 options_.with_ast_visitor = true; 57 options_.with_ast_visitor = true;
60 } else if (args[i] == "check-templates") { 58 } else if (args[i] == "check-templates") {
61 options_.check_templates = true; 59 options_.check_templates = true;
62 } else { 60 } else {
63 parsed = false; 61 parsed = false;
64 llvm::errs() << "Unknown clang plugin argument: " << args[i] << "\n"; 62 llvm::errs() << "Unknown clang plugin argument: " << args[i] << "\n";
65 } 63 }
66 } 64 }
67 65
68 return parsed; 66 return parsed;
69 } 67 }
70 68
71 } // namespace chrome_checker 69 } // namespace chrome_checker
72 70
73 static FrontendPluginRegistry::Add<chrome_checker::FindBadConstructsAction> X( 71 static FrontendPluginRegistry::Add<chrome_checker::FindBadConstructsAction> X(
74 "find-bad-constructs", 72 "find-bad-constructs",
75 "Finds bad C++ constructs"); 73 "Finds bad C++ constructs");
OLDNEW
« no previous file with comments | « no previous file | tools/clang/plugins/FindBadConstructsConsumer.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698