Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Side by Side Diff: tools/clang/plugins/tests/base_refcounted.txt

Issue 938773002: Remove strict-virtual-specifiers option, since it's enabled everywhere. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 In file included from base_refcounted.cpp:5: 1 In file included from base_refcounted.cpp:5:
2 ./base_refcounted.h:47:3: warning: [chromium-style] Classes that are ref-counted should have destructors that are declared protected or private. 2 ./base_refcounted.h:47:3: warning: [chromium-style] Classes that are ref-counted should have destructors that are declared protected or private.
3 ~PublicRefCountedDtorInHeader() {} 3 ~PublicRefCountedDtorInHeader() {}
4 ^ 4 ^
5 ./base_refcounted.h:44:7: note: [chromium-style] 'PublicRefCountedDtorInHeader' inherits from 'base::RefCounted<PublicRefCountedDtorInHeader>' here 5 ./base_refcounted.h:44:7: note: [chromium-style] 'PublicRefCountedDtorInHeader' inherits from 'base::RefCounted<PublicRefCountedDtorInHeader>' here
6 : public base::RefCounted<PublicRefCountedDtorInHeader> { 6 : public base::RefCounted<PublicRefCountedDtorInHeader> {
7 ^ 7 ^
8 ./base_refcounted.h:59:3: warning: [chromium-style] Classes that are ref-counted should have destructors that are declared protected or private. 8 ./base_refcounted.h:59:3: warning: [chromium-style] Classes that are ref-counted should have destructors that are declared protected or private.
9 ~PublicRefCountedThreadSafeDtorInHeader() {} 9 ~PublicRefCountedThreadSafeDtorInHeader() {}
10 ^ 10 ^
11 ./base_refcounted.h:55:7: note: [chromium-style] 'PublicRefCountedThreadSafeDtor InHeader' inherits from 'base::RefCountedThreadSafe<PublicRefCountedThreadSafeDt orInHeader>' here 11 ./base_refcounted.h:55:7: note: [chromium-style] 'PublicRefCountedThreadSafeDtor InHeader' inherits from 'base::RefCountedThreadSafe<PublicRefCountedThreadSafeDt orInHeader>' here
12 : public base::RefCountedThreadSafe< 12 : public base::RefCountedThreadSafe<
13 ^ 13 ^
14 ./base_refcounted.h:73:3: warning: [chromium-style] Classes that are ref-counted and have non-private destructors should declare their destructor virtual. 14 ./base_refcounted.h:73:3: warning: [chromium-style] Classes that are ref-counted and have non-private destructors should declare their destructor virtual.
15 ~ProtectedRefCountedDtorInHeader() {} 15 ~ProtectedRefCountedDtorInHeader() {}
16 ^ 16 ^
17 ./base_refcounted.h:110:3: warning: [chromium-style] Classes that are ref-counte d should have destructors that are declared protected or private. 17 ./base_refcounted.h:110:3: warning: [chromium-style] Classes that are ref-counte d should have destructors that are declared protected or private.
18 virtual ~DerivedProtectedToPublicInHeader() {} 18 ~DerivedProtectedToPublicInHeader() override {}
19 ^ 19 ^
20 ./base_refcounted.h:107:7: note: [chromium-style] 'DerivedProtectedToPublicInHea der' inherits from 'ProtectedRefCountedVirtualDtorInHeader' here 20 ./base_refcounted.h:107:7: note: [chromium-style] 'DerivedProtectedToPublicInHea der' inherits from 'ProtectedRefCountedVirtualDtorInHeader' here
21 : public ProtectedRefCountedVirtualDtorInHeader { 21 : public ProtectedRefCountedVirtualDtorInHeader {
22 ^ 22 ^
23 ./base_refcounted.h:81:7: note: [chromium-style] 'ProtectedRefCountedVirtualDtor InHeader' inherits from 'base::RefCounted<ProtectedRefCountedVirtualDtorInHeader >' here 23 ./base_refcounted.h:81:7: note: [chromium-style] 'ProtectedRefCountedVirtualDtor InHeader' inherits from 'base::RefCounted<ProtectedRefCountedVirtualDtorInHeader >' here
24 : public base::RefCounted<ProtectedRefCountedVirtualDtorInHeader> { 24 : public base::RefCounted<ProtectedRefCountedVirtualDtorInHeader> {
25 ^ 25 ^
26 ./base_refcounted.h:115:7: warning: [chromium-style] Classes that are ref-counte d should have explicit destructors that are declared protected or private. 26 ./base_refcounted.h:115:7: warning: [chromium-style] Classes that are ref-counte d should have explicit destructors that are declared protected or private.
27 class ImplicitDerivedProtectedToPublicInHeader 27 class ImplicitDerivedProtectedToPublicInHeader
28 ^ 28 ^
(...skipping 25 matching lines...) Expand all
54 class AnImplicitInterface { 54 class AnImplicitInterface {
55 ^ 55 ^
56 ./base_refcounted.h:165:7: note: [chromium-style] 'ImplementsAnImplicitInterface ' inherits from 'AnImplicitInterface' here 56 ./base_refcounted.h:165:7: note: [chromium-style] 'ImplementsAnImplicitInterface ' inherits from 'AnImplicitInterface' here
57 : public AnImplicitInterface, 57 : public AnImplicitInterface,
58 ^ 58 ^
59 ./base_refcounted.h:204:3: warning: [chromium-style] Classes that are ref-counte d and have non-private destructors should declare their destructor virtual. 59 ./base_refcounted.h:204:3: warning: [chromium-style] Classes that are ref-counte d and have non-private destructors should declare their destructor virtual.
60 ~RefcountedType() {} 60 ~RefcountedType() {}
61 ^ 61 ^
62 ./base_refcounted.h:204:3: warning: [chromium-style] Classes that are ref-counte d and have non-private destructors should declare their destructor virtual. 62 ./base_refcounted.h:204:3: warning: [chromium-style] Classes that are ref-counte d and have non-private destructors should declare their destructor virtual.
63 base_refcounted.cpp:16:3: warning: [chromium-style] Classes that are ref-counted should have destructors that are declared protected or private. 63 base_refcounted.cpp:16:3: warning: [chromium-style] Classes that are ref-counted should have destructors that are declared protected or private.
64 virtual ~AnonymousDerivedProtectedToPublicInImpl() {} 64 ~AnonymousDerivedProtectedToPublicInImpl() override {}
65 ^ 65 ^
66 base_refcounted.cpp:13:7: note: [chromium-style] 'AnonymousDerivedProtectedToPub licInImpl' inherits from 'ProtectedRefCountedVirtualDtorInHeader' here 66 base_refcounted.cpp:13:7: note: [chromium-style] 'AnonymousDerivedProtectedToPub licInImpl' inherits from 'ProtectedRefCountedVirtualDtorInHeader' here
67 : public ProtectedRefCountedVirtualDtorInHeader { 67 : public ProtectedRefCountedVirtualDtorInHeader {
68 ^ 68 ^
69 ./base_refcounted.h:81:7: note: [chromium-style] 'ProtectedRefCountedVirtualDtor InHeader' inherits from 'base::RefCounted<ProtectedRefCountedVirtualDtorInHeader >' here 69 ./base_refcounted.h:81:7: note: [chromium-style] 'ProtectedRefCountedVirtualDtor InHeader' inherits from 'base::RefCounted<ProtectedRefCountedVirtualDtorInHeader >' here
70 : public base::RefCounted<ProtectedRefCountedVirtualDtorInHeader> { 70 : public base::RefCounted<ProtectedRefCountedVirtualDtorInHeader> {
71 ^ 71 ^
72 ./base_refcounted.h:73:3: warning: [chromium-style] Classes that are ref-counted and have non-private destructors should declare their destructor virtual. 72 ./base_refcounted.h:73:3: warning: [chromium-style] Classes that are ref-counted and have non-private destructors should declare their destructor virtual.
73 ~ProtectedRefCountedDtorInHeader() {} 73 ~ProtectedRefCountedDtorInHeader() {}
74 ^ 74 ^
75 base_refcounted.cpp:33:3: warning: [chromium-style] Classes that are ref-counted should have destructors that are declared protected or private. 75 base_refcounted.cpp:33:3: warning: [chromium-style] Classes that are ref-counted should have destructors that are declared protected or private.
76 ~PublicRefCountedDtorInImpl() {} 76 ~PublicRefCountedDtorInImpl() {}
77 ^ 77 ^
78 base_refcounted.cpp:30:7: note: [chromium-style] 'PublicRefCountedDtorInImpl' in herits from 'base::RefCounted<PublicRefCountedDtorInImpl>' here 78 base_refcounted.cpp:30:7: note: [chromium-style] 'PublicRefCountedDtorInImpl' in herits from 'base::RefCounted<PublicRefCountedDtorInImpl>' here
79 : public base::RefCounted<PublicRefCountedDtorInImpl> { 79 : public base::RefCounted<PublicRefCountedDtorInImpl> {
80 ^ 80 ^
81 base_refcounted.cpp:59:3: warning: [chromium-style] Classes that are ref-counted should have destructors that are declared protected or private. 81 base_refcounted.cpp:59:3: warning: [chromium-style] Classes that are ref-counted should have destructors that are declared protected or private.
82 ~UnsafeTypedefChainInImpl() {} 82 ~UnsafeTypedefChainInImpl() {}
83 ^ 83 ^
84 base_refcounted.cpp:56:34: note: [chromium-style] 'UnsafeTypedefChainInImpl' inh erits from 'Baz::MyLocalTypedef' (aka 'RefCounted<Foo::BarInterface>') here 84 base_refcounted.cpp:56:34: note: [chromium-style] 'UnsafeTypedefChainInImpl' inh erits from 'Baz::MyLocalTypedef' (aka 'RefCounted<Foo::BarInterface>') here
85 class UnsafeTypedefChainInImpl : public Baz::MyLocalTypedef { 85 class UnsafeTypedefChainInImpl : public Baz::MyLocalTypedef {
86 ^ 86 ^
87 13 warnings generated. 87 13 warnings generated.
OLDNEW
« no previous file with comments | « tools/clang/plugins/tests/base_refcounted.cpp ('k') | tools/clang/plugins/tests/overridden_methods.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698