Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 935083003: Move strict-virtual-specifiers flag to be specified in plugin_flags.sh (Closed)

Created:
5 years, 10 months ago by dcheng
Modified:
5 years, 10 months ago
Reviewers:
hans, Nico
CC:
chromium-reviews, hans
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move strict-virtual-specifiers flag to be specified in plugin_flags.sh BUG=417463 Committed: https://crrev.com/6980a79fa23d6c40472a003a14e55a0781ef6a74 Cr-Commit-Position: refs/heads/master@{#316889}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add missing backslash #

Patch Set 3 : Moar Xclang #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -14 lines) Patch
M build/common.gypi View 1 chunk +0 lines, -12 lines 0 comments Download
M tools/clang/scripts/plugin_flags.sh View 1 2 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
dcheng
5 years, 10 months ago (2015-02-18 17:53:59 UTC) #2
hans
https://codereview.chromium.org/935083003/diff/1/tools/clang/scripts/plugin_flags.sh File tools/clang/scripts/plugin_flags.sh (right): https://codereview.chromium.org/935083003/diff/1/tools/clang/scripts/plugin_flags.sh#newcode22 tools/clang/scripts/plugin_flags.sh:22: -plugin-arg-find-bad-constructs -Xclang strict-virtual-specifiers I think this needs more -Xclang?
5 years, 10 months ago (2015-02-18 18:25:51 UTC) #4
dcheng
https://codereview.chromium.org/935083003/diff/1/tools/clang/scripts/plugin_flags.sh File tools/clang/scripts/plugin_flags.sh (right): https://codereview.chromium.org/935083003/diff/1/tools/clang/scripts/plugin_flags.sh#newcode22 tools/clang/scripts/plugin_flags.sh:22: -plugin-arg-find-bad-constructs -Xclang strict-virtual-specifiers On 2015/02/18 18:25:51, hans wrote: > ...
5 years, 10 months ago (2015-02-18 19:33:06 UTC) #5
Nico
lgtm (the flag will be removed from the .sh file in the next clang roll, ...
5 years, 10 months ago (2015-02-18 19:56:36 UTC) #6
dcheng
On 2015/02/18 at 19:56:36, thakis wrote: > lgtm > > (the flag will be removed ...
5 years, 10 months ago (2015-02-18 20:41:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/935083003/40001
5 years, 10 months ago (2015-02-18 20:43:01 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 10 months ago (2015-02-18 20:46:08 UTC) #10
commit-bot: I haz the power
5 years, 10 months ago (2015-02-18 20:46:55 UTC) #11
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/6980a79fa23d6c40472a003a14e55a0781ef6a74
Cr-Commit-Position: refs/heads/master@{#316889}

Powered by Google App Engine
This is Rietveld 408576698