Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Unified Diff: tools/clang/plugins/tests/overridden_methods.txt

Issue 938773002: Remove strict-virtual-specifiers option, since it's enabled everywhere. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/clang/plugins/tests/overridden_methods.txt
diff --git a/tools/clang/plugins/tests/overridden_methods.txt b/tools/clang/plugins/tests/overridden_methods.txt
index 3ee0333aa645459e3d26dc5bcbf5c8b5bdb92304..69ff2b12a6466913af5c4e3921c86aef4e3963eb 100644
--- a/tools/clang/plugins/tests/overridden_methods.txt
+++ b/tools/clang/plugins/tests/overridden_methods.txt
@@ -1,4 +1,12 @@
In file included from overridden_methods.cpp:5:
+./overridden_methods.h:25:28: warning: [chromium-style] Overriding method must be marked with 'override' or 'final'.
+ virtual void SomeMethod() = 0;
+ ^
+ override
+./overridden_methods.h:46:26: warning: [chromium-style] Overriding method must be marked with 'override' or 'final'.
+ virtual ~DerivedClass() {}
+ ^
+ override
./overridden_methods.h:48:28: warning: [chromium-style] Overriding method must be marked with 'override' or 'final'.
virtual void SomeMethod();
^
@@ -31,6 +39,14 @@ In file included from overridden_methods.cpp:5:
virtual void SomeMethodWithCommentAndBody() {} // This is a comment.
^
override
+overridden_methods.cpp:15:28: warning: [chromium-style] Overriding method must be marked with 'override' or 'final'.
+ virtual void SomeMethod() = 0;
+ ^
+ override
+overridden_methods.cpp:22:40: warning: [chromium-style] Overriding method must be marked with 'override' or 'final'.
+ virtual ~ImplementationDerivedClass() {}
+ ^
+ override
overridden_methods.cpp:24:28: warning: [chromium-style] Overriding method must be marked with 'override' or 'final'.
virtual void SomeMethod();
^
@@ -63,4 +79,4 @@ overridden_methods.cpp:43:46: warning: [chromium-style] Overriding method must b
virtual void SomeMethodWithCommentAndBody() {} // This is a comment.
^
override
-16 warnings generated.
+20 warnings generated.
« no previous file with comments | « tools/clang/plugins/tests/overridden_methods.cpp ('k') | tools/clang/plugins/tests/virtual_base_method_also_final.flags » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698