Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1187)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: tools/clang/plugins/tests/overridden_methods.txt

Issue 938773002: Remove strict-virtual-specifiers option, since it's enabled everywhere. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « tools/clang/plugins/tests/overridden_methods.cpp ('k') | tools/clang/plugins/tests/virtual_base_method_also_final.flags » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 In file included from overridden_methods.cpp:5: 1 In file included from overridden_methods.cpp:5:
2 ./overridden_methods.h:25:28: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'.
3 virtual void SomeMethod() = 0;
4 ^
5 override
6 ./overridden_methods.h:46:26: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'.
7 virtual ~DerivedClass() {}
8 ^
9 override
2 ./overridden_methods.h:48:28: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'. 10 ./overridden_methods.h:48:28: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'.
3 virtual void SomeMethod(); 11 virtual void SomeMethod();
4 ^ 12 ^
5 override 13 override
6 ./overridden_methods.h:52:34: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'. 14 ./overridden_methods.h:52:34: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'.
7 virtual void SomeInlineMethod() {} 15 virtual void SomeInlineMethod() {}
8 ^ 16 ^
9 override 17 override
10 ./overridden_methods.h:56:39: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'. 18 ./overridden_methods.h:56:39: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'.
11 virtual void SomeConstMethod() const {} 19 virtual void SomeConstMethod() const {}
(...skipping 12 matching lines...) Expand all
24 ^ 32 ^
25 override 33 override
26 ./overridden_methods.h:65:39: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'. 34 ./overridden_methods.h:65:39: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'.
27 virtual void SomeMethodWithComment(); // This is a comment. 35 virtual void SomeMethodWithComment(); // This is a comment.
28 ^ 36 ^
29 override 37 override
30 ./overridden_methods.h:67:46: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'. 38 ./overridden_methods.h:67:46: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'.
31 virtual void SomeMethodWithCommentAndBody() {} // This is a comment. 39 virtual void SomeMethodWithCommentAndBody() {} // This is a comment.
32 ^ 40 ^
33 override 41 override
42 overridden_methods.cpp:15:28: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'.
43 virtual void SomeMethod() = 0;
44 ^
45 override
46 overridden_methods.cpp:22:40: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'.
47 virtual ~ImplementationDerivedClass() {}
48 ^
49 override
34 overridden_methods.cpp:24:28: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'. 50 overridden_methods.cpp:24:28: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'.
35 virtual void SomeMethod(); 51 virtual void SomeMethod();
36 ^ 52 ^
37 override 53 override
38 overridden_methods.cpp:28:34: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'. 54 overridden_methods.cpp:28:34: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'.
39 virtual void SomeInlineMethod() {} 55 virtual void SomeInlineMethod() {}
40 ^ 56 ^
41 override 57 override
42 overridden_methods.cpp:32:39: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'. 58 overridden_methods.cpp:32:39: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'.
43 virtual void SomeConstMethod() const {} 59 virtual void SomeConstMethod() const {}
(...skipping 12 matching lines...) Expand all
56 ^ 72 ^
57 override 73 override
58 overridden_methods.cpp:41:39: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'. 74 overridden_methods.cpp:41:39: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'.
59 virtual void SomeMethodWithComment(); // This is a comment. 75 virtual void SomeMethodWithComment(); // This is a comment.
60 ^ 76 ^
61 override 77 override
62 overridden_methods.cpp:43:46: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'. 78 overridden_methods.cpp:43:46: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'.
63 virtual void SomeMethodWithCommentAndBody() {} // This is a comment. 79 virtual void SomeMethodWithCommentAndBody() {} // This is a comment.
64 ^ 80 ^
65 override 81 override
66 16 warnings generated. 82 20 warnings generated.
OLDNEW
« no previous file with comments | « tools/clang/plugins/tests/overridden_methods.cpp ('k') | tools/clang/plugins/tests/virtual_base_method_also_final.flags » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698