Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 929503002: Multi-string shaders (Closed)

Created:
5 years, 10 months ago by joshua.litt
Modified:
5 years, 10 months ago
Reviewers:
joshualitt, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : more cleanup #

Patch Set 3 : more #

Patch Set 4 : windows build issue #

Patch Set 5 : windows fix #

Patch Set 6 : windows warning #

Patch Set 7 : windows warning #

Unified diffs Side-by-side diffs Delta from patch set Stats (+279 lines, -178 lines) Patch
M include/gpu/gl/GrGLSLPrettyPrint.h View 1 chunk +4 lines, -1 line 0 comments Download
M src/gpu/gl/builders/GrGLFragmentShaderBuilder.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/builders/GrGLFragmentShaderBuilder.cpp View 2 chunks +8 lines, -23 lines 0 comments Download
M src/gpu/gl/builders/GrGLGeometryShaderBuilder.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/builders/GrGLGeometryShaderBuilder.cpp View 2 chunks +3 lines, -32 lines 0 comments Download
M src/gpu/gl/builders/GrGLProgramBuilder.h View 1 chunk +6 lines, -1 line 0 comments Download
M src/gpu/gl/builders/GrGLSLPrettyPrint.cpp View 1 2 4 chunks +89 lines, -58 lines 0 comments Download
M src/gpu/gl/builders/GrGLShaderBuilder.h View 1 2 3 4 4 chunks +41 lines, -4 lines 0 comments Download
M src/gpu/gl/builders/GrGLShaderBuilder.cpp View 1 2 3 4 5 7 chunks +55 lines, -14 lines 0 comments Download
M src/gpu/gl/builders/GrGLShaderStringBuilder.h View 1 chunk +3 lines, -1 line 0 comments Download
M src/gpu/gl/builders/GrGLShaderStringBuilder.cpp View 4 chunks +19 lines, -11 lines 0 comments Download
M src/gpu/gl/builders/GrGLVertexShaderBuilder.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/builders/GrGLVertexShaderBuilder.cpp View 2 chunks +7 lines, -20 lines 0 comments Download
M tests/GrGLSLPrettyPrintTest.cpp View 1 2 3 4 5 6 3 chunks +41 lines, -10 lines 0 comments Download

Messages

Total messages: 18 (8 generated)
joshualitt
5 years, 10 months ago (2015-02-13 19:40:19 UTC) #2
bsalomon
lgtm
5 years, 10 months ago (2015-02-13 20:25:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/929503002/40001
5 years, 10 months ago (2015-02-13 23:52:27 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: Build-Win-VS2013-x86-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-VS2013-x86-Debug-Trybot/builds/2488)
5 years, 10 months ago (2015-02-13 23:57:39 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/929503002/60001
5 years, 10 months ago (2015-02-14 00:17:37 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/929503002/60001
5 years, 10 months ago (2015-02-14 00:23:37 UTC) #13
commit-bot: I haz the power
Committed patchset #4 (id:60001) as https://skia.googlesource.com/skia/+/1c3c2d83364ee228e0751df0e1b9c161c0ba8c1e
5 years, 10 months ago (2015-02-14 00:23:53 UTC) #14
joshualitt
A revert of this CL (patchset #4 id:60001) has been created in https://codereview.chromium.org/924973002/ by joshualitt@google.com. ...
5 years, 10 months ago (2015-02-14 00:31:04 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/929503002/120001
5 years, 10 months ago (2015-02-14 01:12:58 UTC) #17
commit-bot: I haz the power
5 years, 10 months ago (2015-02-14 01:18:31 UTC) #18
Message was sent while issue was closed.
Committed patchset #7 (id:120001) as
https://skia.googlesource.com/skia/+/43466a1ade066f96823dbc7963767da3973afd91

Powered by Google App Engine
This is Rietveld 408576698