Issue 924973002: Revert of Multi-string shaders

Issue 924973002: Revert of Multi-string shaders (Closed)

Created:
5 years, 10 months ago by joshualitt

Modified:
5 years, 10 months ago

Reviewers:
bsalomon, joshua.litt

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

Revert of Multi-string shaders (patchset #4 id:60001 of https://codereview.chromium.org/929503002/) Reason for revert: windows warnings Original issue's description: > Multi-string shaders > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/1c3c2d83364ee228e0751df0e1b9c161c0ba8c1e TBR=bsalomon@google.com,joshualitt@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/b8a82f2bce265a09173a90dfbe4ce78e52347ba4

Created: 5 years, 10 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+179 lines, -280 lines)			Patch
M	include/gpu/gl/GrGLSLPrettyPrint.h	View	1 chunk	+1 line, -4 lines	0 comments	Download
M	src/gpu/gl/builders/GrGLFragmentShaderBuilder.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/gpu/gl/builders/GrGLFragmentShaderBuilder.cpp	View	2 chunks	+23 lines, -8 lines	0 comments	Download
M	src/gpu/gl/builders/GrGLGeometryShaderBuilder.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/gpu/gl/builders/GrGLGeometryShaderBuilder.cpp	View	2 chunks	+32 lines, -3 lines	0 comments	Download
M	src/gpu/gl/builders/GrGLProgramBuilder.h	View	1 chunk	+1 line, -6 lines	0 comments	Download
M	src/gpu/gl/builders/GrGLSLPrettyPrint.cpp	View	4 chunks	+58 lines, -89 lines	0 comments	Download
M	src/gpu/gl/builders/GrGLShaderBuilder.h	View	4 chunks	+4 lines, -41 lines	0 comments	Download
M	src/gpu/gl/builders/GrGLShaderBuilder.cpp	View	7 chunks	+14 lines, -55 lines	0 comments	Download
M	src/gpu/gl/builders/GrGLShaderStringBuilder.h	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	src/gpu/gl/builders/GrGLShaderStringBuilder.cpp	View	4 chunks	+12 lines, -20 lines	0 comments	Download
M	src/gpu/gl/builders/GrGLVertexShaderBuilder.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/gpu/gl/builders/GrGLVertexShaderBuilder.cpp	View	2 chunks	+20 lines, -7 lines	0 comments	Download
M	tests/GrGLSLPrettyPrintTest.cpp	View	3 chunks	+10 lines, -41 lines	0 comments	Download

Total messages: 3 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/924973002/1

5 years, 10 months ago (2015-02-14 00:31:37 UTC) #2

commit-bot: I haz the power

5 years, 10 months ago (2015-02-14 00:31:50 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/b8a82f2bce265a09173a90dfbe4ce78e52347ba4