Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 906613005: Add glUniformBlockBinding to GPU command buffer. (Closed)

Created:
5 years, 10 months ago by Zhenyao Mo
Modified:
5 years, 10 months ago
Reviewers:
piman
CC:
chromium-reviews, Ken Russell (switch to Gerrit), bajones, no sievers, vmiura
Base URL:
https://chromium.googlesource.com/chromium/src.git@uniform
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add glUniformBlockBinding to GPU command buffer. This is a simple command, except we need to update client side caching of uniform block info accordingly. BUG=429053 TEST=gpu_unittests R=piman@chromium.org Committed: https://crrev.com/8fab00cbccd157c8f733656b7812d81570985753 Cr-Commit-Position: refs/heads/master@{#315167}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+293 lines, -113 lines) Patch
M gpu/GLES2/gl2chromium_autogen.h View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/build_gles2_cmd_buffer.py View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_c_lib_autogen.h View 2 chunks +7 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_cmd_helper_autogen.h View 1 chunk +8 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation.cc View 1 2 1 chunk +13 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation_autogen.h View 1 chunk +2 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation_unittest_autogen.h View 1 chunk +11 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_interface_autogen.h View 1 chunk +3 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_interface_stub_autogen.h View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_interface_stub_impl_autogen.h View 1 chunk +4 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_trace_implementation_autogen.h View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_trace_implementation_impl_autogen.h View 1 chunk +7 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/program_info_manager.h View 1 2 2 chunks +8 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/program_info_manager.cc View 1 2 2 chunks +21 lines, -0 lines 3 comments Download
M gpu/command_buffer/client/program_info_manager_unittest.cc View 1 2 3 1 chunk +7 lines, -7 lines 0 comments Download
M gpu/command_buffer/cmd_buffer_functions.txt View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_format_autogen.h View 1 chunk +41 lines, -0 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_format_test_autogen.h View 1 chunk +13 lines, -0 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_ids_autogen.h View 1 chunk +92 lines, -91 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 2 2 chunks +20 lines, -1 line 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_2_autogen.h View 1 2 chunks +1 line, -14 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_3_autogen.h View 1 chunk +14 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_programs.cc View 1 2 3 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Zhenyao Mo
piman: please review. Others: FYI (feel free to review)
5 years, 10 months ago (2015-02-07 00:40:46 UTC) #2
piman
LGTM+nit https://codereview.chromium.org/906613005/diff/70001/gpu/command_buffer/client/program_info_manager.cc File gpu/command_buffer/client/program_info_manager.cc (right): https://codereview.chromium.org/906613005/diff/70001/gpu/command_buffer/client/program_info_manager.cc#newcode652 gpu/command_buffer/client/program_info_manager.cc:652: if (binding < max_bindings) { nit: do we ...
5 years, 10 months ago (2015-02-07 01:16:32 UTC) #3
Zhenyao Mo
https://codereview.chromium.org/906613005/diff/70001/gpu/command_buffer/client/program_info_manager.cc File gpu/command_buffer/client/program_info_manager.cc (right): https://codereview.chromium.org/906613005/diff/70001/gpu/command_buffer/client/program_info_manager.cc#newcode652 gpu/command_buffer/client/program_info_manager.cc:652: if (binding < max_bindings) { On 2015/02/07 01:16:32, piman ...
5 years, 10 months ago (2015-02-07 01:48:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/906613005/70001
5 years, 10 months ago (2015-02-07 01:49:45 UTC) #6
piman
https://codereview.chromium.org/906613005/diff/70001/gpu/command_buffer/client/program_info_manager.cc File gpu/command_buffer/client/program_info_manager.cc (right): https://codereview.chromium.org/906613005/diff/70001/gpu/command_buffer/client/program_info_manager.cc#newcode652 gpu/command_buffer/client/program_info_manager.cc:652: if (binding < max_bindings) { On 2015/02/07 01:48:43, Zhenyao ...
5 years, 10 months ago (2015-02-07 01:50:58 UTC) #7
commit-bot: I haz the power
Committed patchset #5 (id:70001)
5 years, 10 months ago (2015-02-07 02:45:21 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-07 02:46:13 UTC) #9
Message was sent while issue was closed. 
Patchset 5 (id:??) landed as
https://crrev.com/8fab00cbccd157c8f733656b7812d81570985753
Cr-Commit-Position: refs/heads/master@{#315167}

Powered by Google App Engine
This is Rietveld 408576698