Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Unified Diff: gpu/command_buffer/client/program_info_manager_unittest.cc

Issue 906613005: Add glUniformBlockBinding to GPU command buffer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@uniform
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gpu/command_buffer/client/program_info_manager_unittest.cc
diff --git a/gpu/command_buffer/client/program_info_manager_unittest.cc b/gpu/command_buffer/client/program_info_manager_unittest.cc
index 316faa203b7777d457a4caf570d023d831e1841b..ce0802d25d27da72aa15ebbfe627a37ffd4955ef 100644
--- a/gpu/command_buffer/client/program_info_manager_unittest.cc
+++ b/gpu/command_buffer/client/program_info_manager_unittest.cc
@@ -191,36 +191,36 @@ TEST_F(ProgramInfoManagerTest, GetActiveUniformBlockivCached) {
for (uint32_t ii = 0; ii < data.header.num_uniform_blocks; ++ii) {
ASSERT_GE(2u, data.entry[ii].active_uniforms);
GLint params[2];
- EXPECT_EQ(true, program_info_manager_->GetActiveUniformBlockiv(
+ EXPECT_TRUE(program_info_manager_->GetActiveUniformBlockiv(
NULL, kClientProgramId, ii, GL_UNIFORM_BLOCK_BINDING, params));
EXPECT_EQ(data.entry[ii].binding, static_cast<uint32_t>(params[0]));
- EXPECT_EQ(true, program_info_manager_->GetActiveUniformBlockiv(
+ EXPECT_TRUE(program_info_manager_->GetActiveUniformBlockiv(
NULL, kClientProgramId, ii, GL_UNIFORM_BLOCK_DATA_SIZE, params));
EXPECT_EQ(data.entry[ii].data_size, static_cast<uint32_t>(params[0]));
- EXPECT_EQ(true, program_info_manager_->GetActiveUniformBlockiv(
+ EXPECT_TRUE(program_info_manager_->GetActiveUniformBlockiv(
NULL, kClientProgramId, ii, GL_UNIFORM_BLOCK_NAME_LENGTH, params));
EXPECT_EQ(strlen(kName[ii]) + 1, static_cast<uint32_t>(params[0]));
- EXPECT_EQ(true, program_info_manager_->GetActiveUniformBlockiv(
+ EXPECT_TRUE(program_info_manager_->GetActiveUniformBlockiv(
NULL, kClientProgramId, ii, GL_UNIFORM_BLOCK_ACTIVE_UNIFORMS, params));
EXPECT_EQ(data.entry[ii].active_uniforms, static_cast<uint32_t>(params[0]));
- EXPECT_EQ(true, program_info_manager_->GetActiveUniformBlockiv(
+ EXPECT_TRUE(program_info_manager_->GetActiveUniformBlockiv(
NULL, kClientProgramId, ii,
GL_UNIFORM_BLOCK_ACTIVE_UNIFORM_INDICES, params));
for (uint32_t uu = 0; uu < data.entry[ii].active_uniforms; ++uu) {
EXPECT_EQ(kIndices[ii][uu], static_cast<uint32_t>(params[uu]));
}
- EXPECT_EQ(true, program_info_manager_->GetActiveUniformBlockiv(
+ EXPECT_TRUE(program_info_manager_->GetActiveUniformBlockiv(
NULL, kClientProgramId, ii,
GL_UNIFORM_BLOCK_REFERENCED_BY_VERTEX_SHADER, params));
EXPECT_EQ(data.entry[ii].referenced_by_vertex_shader,
static_cast<uint32_t>(params[0]));
- EXPECT_EQ(true, program_info_manager_->GetActiveUniformBlockiv(
+ EXPECT_TRUE(program_info_manager_->GetActiveUniformBlockiv(
NULL, kClientProgramId, ii,
GL_UNIFORM_BLOCK_REFERENCED_BY_FRAGMENT_SHADER, params));
EXPECT_EQ(data.entry[ii].referenced_by_fragment_shader,

Powered by Google App Engine
This is Rietveld 408576698