Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issue 9026017: Move some more files into ash... this time seed the window manager dir. (Closed)

Created:
9 years ago by Ben Goodger (Google)
Modified:
9 years ago
Reviewers:
sky
CC:
chromium-reviews, dhollowa+watch_chromium.org, ben+watch_chromium.org, sadrul, Paweł Hajdan Jr., tfarina
Visibility:
Public.

Description

Move some more files into ash... this time seed the window manager dir. http://crbug.com/108457 TEST=none TBR=sky Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=115655

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -2761 lines) Patch
M ash/shell/window_type_launcher.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
A + ash/wm/activation_controller.h View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
A + ash/wm/activation_controller.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
A + ash/wm/activation_controller_unittest.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
A + ash/wm/always_on_top_controller.h View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
A + ash/wm/always_on_top_controller.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
A + ash/wm/image_grid.h View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
A + ash/wm/image_grid.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
A + ash/wm/image_grid_unittest.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
A + ash/wm/modal_container_layout_manager.h View 1 2 3 4 2 chunks +4 lines, -4 lines 0 comments Download
A + ash/wm/modal_container_layout_manager.cc View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
A + ash/wm/modal_container_layout_manager_unittest.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
A + ash/wm/modality_event_filter.h View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
A + ash/wm/modality_event_filter.cc View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
A + ash/wm/modality_event_filter_delegate.h View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
A + ash/wm/shadow.h View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
A + ash/wm/shadow.cc View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
A + ash/wm/shadow_controller.h View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
A + ash/wm/shadow_controller.cc View 1 2 3 4 1 chunk +3 lines, -3 lines 0 comments Download
A + ash/wm/shadow_controller_unittest.cc View 1 2 3 4 1 chunk +3 lines, -3 lines 0 comments Download
A + ash/wm/shadow_types.h View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
A + ash/wm/shadow_types.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
A + ash/wm/show_state_controller.h View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
A + ash/wm/show_state_controller.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
A + ash/wm/stacking_controller.h View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
A + ash/wm/stacking_controller.cc View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
A + ash/wm/stacking_controller_unittest.cc View 1 2 3 4 0 chunks +-1 lines, --1 lines 0 comments Download
M ui/aura_shell/DEPS View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
D ui/aura_shell/activation_controller.h View 1 2 3 4 1 chunk +0 lines, -77 lines 0 comments Download
D ui/aura_shell/activation_controller.cc View 1 2 3 4 1 chunk +0 lines, -187 lines 0 comments Download
D ui/aura_shell/activation_controller_unittest.cc View 1 2 3 4 1 chunk +0 lines, -280 lines 0 comments Download
D ui/aura_shell/always_on_top_controller.h View 1 2 3 4 1 chunk +0 lines, -54 lines 0 comments Download
D ui/aura_shell/always_on_top_controller.cc View 1 2 3 4 1 chunk +0 lines, -79 lines 0 comments Download
M ui/aura_shell/aura_shell.gyp View 1 2 3 4 7 chunks +25 lines, -25 lines 0 comments Download
M ui/aura_shell/default_container_layout_manager.cc View 1 2 3 4 2 chunks +1 line, -1 line 0 comments Download
D ui/aura_shell/image_grid.h View 1 2 3 4 1 chunk +0 lines, -212 lines 0 comments Download
D ui/aura_shell/image_grid.cc View 1 2 3 4 1 chunk +0 lines, -246 lines 0 comments Download
D ui/aura_shell/image_grid_unittest.cc View 1 2 3 4 1 chunk +0 lines, -272 lines 0 comments Download
D ui/aura_shell/modal_container_layout_manager.h View 1 2 3 4 1 chunk +0 lines, -102 lines 0 comments Download
D ui/aura_shell/modal_container_layout_manager.cc View 1 2 3 4 1 chunk +0 lines, -190 lines 0 comments Download
D ui/aura_shell/modal_container_layout_manager_unittest.cc View 1 2 3 4 1 chunk +0 lines, -174 lines 0 comments Download
D ui/aura_shell/modality_event_filter.h View 1 2 3 4 1 chunk +0 lines, -42 lines 0 comments Download
D ui/aura_shell/modality_event_filter.cc View 1 2 3 4 1 chunk +0 lines, -40 lines 0 comments Download
D ui/aura_shell/modality_event_filter_delegate.h View 1 2 3 4 1 chunk +0 lines, -27 lines 0 comments Download
M ui/aura_shell/root_window_event_filter.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M ui/aura_shell/root_window_event_filter_unittest.cc View 1 2 3 4 2 chunks +1 line, -1 line 0 comments Download
D ui/aura_shell/shadow.h View 1 2 3 4 1 chunk +0 lines, -54 lines 0 comments Download
D ui/aura_shell/shadow.cc View 1 2 3 4 1 chunk +0 lines, -54 lines 0 comments Download
D ui/aura_shell/shadow_controller.h View 1 2 3 4 1 chunk +0 lines, -89 lines 0 comments Download
D ui/aura_shell/shadow_controller.cc View 1 2 3 4 1 chunk +0 lines, -117 lines 0 comments Download
D ui/aura_shell/shadow_controller_unittest.cc View 1 2 3 4 1 chunk +0 lines, -91 lines 0 comments Download
D ui/aura_shell/shadow_types.h View 1 2 3 4 1 chunk +0 lines, -33 lines 0 comments Download
D ui/aura_shell/shadow_types.cc View 1 2 3 4 1 chunk +0 lines, -22 lines 0 comments Download
M ui/aura_shell/shell.cc View 1 2 3 4 2 chunks +4 lines, -4 lines 0 comments Download
D ui/aura_shell/show_state_controller.h View 1 2 3 4 1 chunk +0 lines, -44 lines 0 comments Download
D ui/aura_shell/show_state_controller.cc View 1 2 3 4 1 chunk +0 lines, -47 lines 0 comments Download
D ui/aura_shell/stacking_controller.h View 1 2 3 4 1 chunk +0 lines, -43 lines 0 comments Download
D ui/aura_shell/stacking_controller.cc View 1 2 3 4 1 chunk +0 lines, -94 lines 0 comments Download
M ui/aura_shell/window_util.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M ui/aura_shell/workspace/workspace_manager_unittest.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M ui/aura_shell/workspace_controller_unittest.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Ben Goodger (Google)
9 years ago (2011-12-23 01:03:28 UTC) #1
tfarina
http://codereview.chromium.org/9026017/diff/1/ash/wm/show_state_controller.h File ash/wm/show_state_controller.h (right): http://codereview.chromium.org/9026017/diff/1/ash/wm/show_state_controller.h#newcode17 ash/wm/show_state_controller.h:17: namespace aura_shell { namespace ash ?
9 years ago (2011-12-23 01:06:07 UTC) #2
Ben Goodger (Google)
9 years ago (2011-12-23 01:10:10 UTC) #3
I am going to do that later, in one swoop. It's too much of a PITA to do it
in conjunction with this move.

-Ben

On Thu, Dec 22, 2011 at 5:06 PM, <tfarina@chromium.org> wrote:

>
> http://codereview.chromium.**org/9026017/diff/1/ash/wm/**
>
show_state_controller.h<http://codereview.chromium.org/9026017/diff/1/ash/wm/show_state_controller.h>
> File ash/wm/show_state_controller.h (right):
>
> http://codereview.chromium.**org/9026017/diff/1/ash/wm/**
>
show_state_controller.h#**newcode17<http://codereview.chromium.org/9026017/diff/1/ash/wm/show_state_controller.h#newcode17>
> ash/wm/show_state_controller.**h:17: namespace aura_shell {
> namespace ash ?
>
>
http://codereview.chromium.**org/9026017/<http://codereview.chromium.org/9026...
>

Powered by Google App Engine
This is Rietveld 408576698