Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 901663007: Revert of Move DstCopy on gpu into the GrXferProcessor. (Closed)

Created:
5 years, 10 months ago by bsalomon
Modified:
5 years, 10 months ago
Reviewers:
joshualitt, egdaniel
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Move DstCopy on gpu into the GrXferProcessor. (patchset #11 id:200001 of https://codereview.chromium.org/885923002/) Reason for revert: Testing to see if reverting fixes 10.9 bots. Original issue's description: > Move DstCopy on gpu into the GrXferProcessor. > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/74a11753604768bf461b80cabb66060e8564d82c > > Committed: https://skia.googlesource.com/skia/+/5e1378d0e075a323144ba14e0a4cbcca35eccc69 TBR=joshualitt@google.com,egdaniel@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/21b2c53218ab25f4268e3992e51d916076a2a7ee

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+403 lines, -443 lines) Patch
M gyp/gpu.gypi View 2 chunks +0 lines, -3 lines 0 comments Download
M include/gpu/GrXferProcessor.h View 7 chunks +21 lines, -58 lines 0 comments Download
M include/gpu/effects/GrPorterDuffXferProcessor.h View 4 chunks +10 lines, -15 lines 0 comments Download
M src/effects/SkArithmeticMode_gpu.h View 5 chunks +12 lines, -19 lines 0 comments Download
M src/effects/SkArithmeticMode_gpu.cpp View 3 chunks +31 lines, -32 lines 0 comments Download
M src/gpu/GrBatchTarget.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/gpu/GrBatchTarget.cpp View 2 chunks +4 lines, -2 lines 0 comments Download
M src/gpu/GrDrawTarget.h View 4 chunks +6 lines, -5 lines 0 comments Download
M src/gpu/GrDrawTarget.cpp View 8 chunks +44 lines, -10 lines 0 comments Download
M src/gpu/GrGpu.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/GrInOrderDrawBuffer.h View 4 chunks +7 lines, -6 lines 0 comments Download
M src/gpu/GrInOrderDrawBuffer.cpp View 7 chunks +14 lines, -20 lines 0 comments Download
M src/gpu/GrPipeline.h View 2 chunks +5 lines, -2 lines 0 comments Download
M src/gpu/GrPipeline.cpp View 5 chunks +12 lines, -5 lines 0 comments Download
M src/gpu/GrPipelineBuilder.h View 1 chunk +4 lines, -3 lines 0 comments Download
M src/gpu/GrPipelineBuilder.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/GrProgramDesc.h View 2 chunks +17 lines, -0 lines 0 comments Download
M src/gpu/GrTest.cpp View 1 chunk +1 line, -0 lines 0 comments Download
D src/gpu/GrXferProcessor.cpp View 1 chunk +0 lines, -58 lines 0 comments Download
M src/gpu/effects/GrCoverageSetOpXP.h View 4 chunks +7 lines, -8 lines 0 comments Download
M src/gpu/effects/GrCoverageSetOpXP.cpp View 4 chunks +16 lines, -18 lines 0 comments Download
M src/gpu/effects/GrCustomXfermode.cpp View 2 chunks +20 lines, -20 lines 0 comments Download
M src/gpu/effects/GrCustomXfermodePriv.h View 5 chunks +12 lines, -15 lines 0 comments Download
M src/gpu/effects/GrDisableColorXP.h View 4 chunks +7 lines, -8 lines 0 comments Download
M src/gpu/effects/GrDisableColorXP.cpp View 4 chunks +8 lines, -10 lines 0 comments Download
M src/gpu/effects/GrPorterDuffXferProcessor.cpp View 5 chunks +19 lines, -30 lines 0 comments Download
M src/gpu/gl/GrGLGpu.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/gl/GrGLGpu.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M src/gpu/gl/GrGLProgram.cpp View 2 chunks +31 lines, -4 lines 0 comments Download
M src/gpu/gl/GrGLProgramDesc.h View 2 chunks +3 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGLProgramDesc.cpp View 2 chunks +16 lines, -1 line 0 comments Download
M src/gpu/gl/GrGLXferProcessor.h View 2 chunks +4 lines, -14 lines 0 comments Download
D src/gpu/gl/GrGLXferProcessor.cpp View 1 chunk +0 lines, -69 lines 0 comments Download
M src/gpu/gl/builders/GrGLFragmentShaderBuilder.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/gl/builders/GrGLFragmentShaderBuilder.cpp View 1 chunk +49 lines, -2 lines 0 comments Download
M src/gpu/gl/builders/GrGLProgramBuilder.h View 1 chunk +5 lines, -0 lines 0 comments Download
M src/gpu/gl/builders/GrGLProgramBuilder.cpp View 1 chunk +6 lines, -0 lines 0 comments Download
M tests/GLProgramsTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
bsalomon
Created Revert of Move DstCopy on gpu into the GrXferProcessor.
5 years, 10 months ago (2015-02-05 22:16:41 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/901663007/1
5 years, 10 months ago (2015-02-05 22:17:38 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/21b2c53218ab25f4268e3992e51d916076a2a7ee
5 years, 10 months ago (2015-02-05 22:18:09 UTC) #3
bsalomon
5 years, 10 months ago (2015-02-06 15:01:51 UTC) #4
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/873723009/ by bsalomon@google.com.

The reason for reverting is: The revert didn't help the 10.9 bot. Unreverting by
reverting the revert (which is basically relanding the original patch which
itself was a revert of a revert). Revert..

Powered by Google App Engine
This is Rietveld 408576698