Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8968022: Shell related switches -> aura shell switches. (Closed)

Created:
9 years ago by Ben Goodger (Google)
Modified:
9 years ago
Reviewers:
sky
CC:
chromium-reviews, sadrul, tfarina, dhollowa+watch_chromium.org, ben+watch_chromium.org, dcheng, Paweł Hajdan Jr.
Visibility:
Public.

Description

Shell related switches -> aura shell switches. Aura client window properties->client namespace. Move WindowType to client. BUG=none TEST=existing automation TBR=sky Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=115182

Patch Set 1 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+252 lines, -234 lines) Patch
M chrome/browser/about_flags.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/automation/testing_automation_provider_aura.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/fullscreen_aura.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/frame/browser_frame.cc View 4 chunks +7 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_frame_aura.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_non_client_frame_view_factory_aura.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 4 chunks +6 lines, -5 lines 0 comments Download
M ui/aura/aura.gyp View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/aura/aura_switches.h View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/aura/aura_switches.cc View 1 chunk +0 lines, -13 lines 0 comments Download
M ui/aura/client/activation_client.h View 1 chunk +8 lines, -0 lines 0 comments Download
M ui/aura/client/activation_client.cc View 1 chunk +3 lines, -1 line 0 comments Download
M ui/aura/client/activation_delegate.h View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/aura/client/activation_delegate.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ui/aura/client/aura_constants.h View 2 chunks +2 lines, -32 lines 0 comments Download
M ui/aura/client/aura_constants.cc View 1 chunk +2 lines, -8 lines 0 comments Download
M ui/aura/client/drag_drop_client.h View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/aura/client/drag_drop_client.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ui/aura/client/drag_drop_delegate.h View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/aura/client/drag_drop_delegate.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ui/aura/client/stacking_client.h View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/aura/client/stacking_client.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ui/aura/client/tooltip_client.h View 1 chunk +8 lines, -0 lines 0 comments Download
M ui/aura/client/tooltip_client.cc View 1 chunk +3 lines, -1 line 0 comments Download
A + ui/aura/client/window_types.h View 1 chunk +7 lines, -2 lines 0 comments Download
M ui/aura/test/test_windows.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/aura/test/test_windows.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/aura/window.h View 3 chunks +4 lines, -4 lines 0 comments Download
M ui/aura/window.cc View 3 chunks +2 lines, -3 lines 0 comments Download
D ui/aura/window_types.h View 1 chunk +0 lines, -26 lines 0 comments Download
M ui/aura_shell/activation_controller.cc View 4 chunks +7 lines, -6 lines 0 comments Download
M ui/aura_shell/activation_controller_unittest.cc View 2 chunks +1 line, -2 lines 0 comments Download
M ui/aura_shell/always_on_top_controller.cc View 3 chunks +5 lines, -6 lines 0 comments Download
M ui/aura_shell/aura_shell.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
A ui/aura_shell/aura_shell_switches.h View 1 chunk +23 lines, -0 lines 0 comments Download
A ui/aura_shell/aura_shell_switches.cc View 1 chunk +24 lines, -0 lines 0 comments Download
M ui/aura_shell/default_container_layout_manager.cc View 4 chunks +7 lines, -6 lines 0 comments Download
M ui/aura_shell/default_container_layout_manager_unittest.cc View 6 chunks +10 lines, -9 lines 0 comments Download
M ui/aura_shell/drag_drop_controller.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ui/aura_shell/drag_drop_controller_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ui/aura_shell/laptop_mode_layout_manager.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M ui/aura_shell/modal_container_layout_manager.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M ui/aura_shell/property_util.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/aura_shell/root_window_event_filter_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ui/aura_shell/shadow_controller.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M ui/aura_shell/shadow_controller_unittest.cc View 3 chunks +2 lines, -3 lines 0 comments Download
M ui/aura_shell/shell.cc View 3 chunks +4 lines, -7 lines 0 comments Download
M ui/aura_shell/show_state_controller.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M ui/aura_shell/stacking_controller.cc View 2 chunks +6 lines, -5 lines 0 comments Download
M ui/aura_shell/tooltip_controller.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/aura_shell/toplevel_layout_manager.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M ui/aura_shell/toplevel_layout_manager_unittest.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M ui/aura_shell/toplevel_window_event_filter.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M ui/aura_shell/window_util.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/aura_shell/window_util.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/aura_shell/workspace/workspace.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ui/aura_shell/workspace/workspace_manager_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M ui/aura_shell/workspace_controller.cc View 2 chunks +2 lines, -1 line 0 comments Download
M ui/views/widget/native_widget_aura.cc View 11 chunks +23 lines, -21 lines 0 comments Download
M ui/views/widget/tooltip_manager_aura.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Ben Goodger (Google)
9 years ago (2011-12-16 20:55:54 UTC) #1
sky
LGTM
9 years ago (2011-12-16 21:01:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ben@chromium.org/8968022/1065
9 years ago (2011-12-19 19:46:21 UTC) #3
commit-bot: I haz the power
9 years ago (2011-12-19 19:46:45 UTC) #4 
Can't apply patch for file chrome/browser/about_flags.cc.
While running patch -p0 --forward --force;
patching file chrome/browser/about_flags.cc
Hunk #2 succeeded at 443 (offset 8 lines).
Hunk #3 FAILED at 461.
1 out of 3 hunks FAILED -- saving rejects to file
chrome/browser/about_flags.cc.rej

Powered by Google App Engine
This is Rietveld 408576698