Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Issue 896663006: win: Resolve zero-length array errors on MSVC (Closed)

Created:
5 years, 10 months ago by scottmg
Modified:
5 years, 10 months ago
Reviewers:
Mark Mentovai
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@minidump-comp
Target Ref:
refs/heads/master
Project:
crashpad
Visibility:
Public.

Description

win: Resolve zero-length array errors on MSVC In some cases, it's sufficient to move the zero-length array to the end of the structure. When the struct is used inside a class that is derived from however, this fails. In that case, switch to holding the object in a scoped_ptr. Longer winded version: https://groups.google.com/a/chromium.org/d/msg/crashpad-dev/NGZ6LwRMORM/nKcXKQ7inIEJ R=mark@chromium.org BUG=crashpad:1 Committed: https://chromium.googlesource.com/crashpad/crashpad/+/74a34e9c4b2bad67e29e265de90af2af405cec7d

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Total comments: 4

Patch Set 5 : fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -29 lines) Patch
M minidump/minidump_extensions.h View 1 2 3 4 2 chunks +14 lines, -0 lines 0 comments Download
M minidump/minidump_location_descriptor_list_writer.h View 1 chunk +1 line, -1 line 0 comments Download
M minidump/minidump_location_descriptor_list_writer.cc View 1 2 3 4 4 chunks +6 lines, -5 lines 0 comments Download
M minidump/minidump_memory_writer.h View 1 chunk +1 line, -1 line 0 comments Download
M minidump/minidump_memory_writer.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M minidump/minidump_module_writer.h View 1 chunk +1 line, -1 line 0 comments Download
M minidump/minidump_module_writer.cc View 1 chunk +1 line, -1 line 0 comments Download
M minidump/minidump_rva_list_writer.h View 1 1 chunk +1 line, -1 line 0 comments Download
M minidump/minidump_rva_list_writer.cc View 1 4 chunks +5 lines, -5 lines 0 comments Download
M minidump/minidump_simple_string_dictionary_writer.h View 1 chunk +2 lines, -2 lines 0 comments Download
M minidump/minidump_simple_string_dictionary_writer.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M minidump/minidump_string_writer.h View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M minidump/minidump_string_writer.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M minidump/minidump_thread_writer.h View 1 chunk +1 line, -1 line 0 comments Download
M minidump/minidump_thread_writer.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
scottmg
5 years, 10 months ago (2015-02-04 05:55:32 UTC) #1
Mark Mentovai
LGTM otherwise https://codereview.chromium.org/896663006/diff/60001/minidump/minidump_extensions.h File minidump/minidump_extensions.h (right): https://codereview.chromium.org/896663006/diff/60001/minidump/minidump_extensions.h#newcode33 minidump/minidump_extensions.h:33: #pragma warning(disable: 4200) Can we undisable it ...
5 years, 10 months ago (2015-02-04 21:25:15 UTC) #2
scottmg
https://codereview.chromium.org/896663006/diff/60001/minidump/minidump_extensions.h File minidump/minidump_extensions.h (right): https://codereview.chromium.org/896663006/diff/60001/minidump/minidump_extensions.h#newcode33 minidump/minidump_extensions.h:33: #pragma warning(disable: 4200) On 2015/02/04 21:25:15, Mark Mentovai wrote: ...
5 years, 10 months ago (2015-02-05 01:33:26 UTC) #4
scottmg
5 years, 10 months ago (2015-02-05 01:34:47 UTC) #5
Message was sent while issue was closed.
Committed patchset #5 (id:80001) manually as
74a34e9c4b2bad67e29e265de90af2af405cec7d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698