minidump/minidump_string_writer.h - Issue 896663006: win: Resolve zero-length array errors on MSVC

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: minidump/minidump_string_writer.h

Issue 896663006: win: Resolve zero-length array errors on MSVC (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@minidump-comp

Patch Set: fixes Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: minidump/minidump_string_writer.h

diff --git a/minidump/minidump_string_writer.h b/minidump/minidump_string_writer.h

index e4d6243aa891073c26db7e244544da36c6b561ee..ec57179ee9a092e6d9fcedb121ca565badbed248 100644

--- a/minidump/minidump_string_writer.h

+++ b/minidump/minidump_string_writer.h

@@ -22,6 +22,7 @@

#include <vector>

#include "base/basictypes.h"

+#include "base/memory/scoped_ptr.h"

#include "base/strings/string16.h"

#include "minidump/minidump_extensions.h"

#include "minidump/minidump_rva_list_writer.h"

@@ -75,7 +76,7 @@ class MinidumpStringWriter : public MinidumpWritable {

const StringType& string() const { return string_; }

private:

- MinidumpStringType string_base_;

+ scoped_ptr<MinidumpStringType> string_base_;

StringType string_;

DISALLOW_COPY_AND_ASSIGN(MinidumpStringWriter);

« no previous file with comments | « minidump/minidump_simple_string_dictionary_writer.cc ('k') | minidump/minidump_string_writer.cc » ('j') | no next file with comments »