Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(417)

Side by Side Diff: minidump/minidump_module_writer.cc

Issue 896663006: win: Resolve zero-length array errors on MSVC (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@minidump-comp
Patch Set: fixes Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « minidump/minidump_module_writer.h ('k') | minidump/minidump_rva_list_writer.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Crashpad Authors. All rights reserved. 1 // Copyright 2014 The Crashpad Authors. All rights reserved.
2 // 2 //
3 // Licensed under the Apache License, Version 2.0 (the "License"); 3 // Licensed under the Apache License, Version 2.0 (the "License");
4 // you may not use this file except in compliance with the License. 4 // you may not use this file except in compliance with the License.
5 // You may obtain a copy of the License at 5 // You may obtain a copy of the License at
6 // 6 //
7 // http://www.apache.org/licenses/LICENSE-2.0 7 // http://www.apache.org/licenses/LICENSE-2.0
8 // 8 //
9 // Unless required by applicable law or agreed to in writing, software 9 // Unless required by applicable law or agreed to in writing, software
10 // distributed under the License is distributed on an "AS IS" BASIS, 10 // distributed under the License is distributed on an "AS IS" BASIS,
(...skipping 357 matching lines...) Expand 10 before | Expand all | Expand 10 after
368 bool MinidumpModuleWriter::WriteObject(FileWriterInterface* file_writer) { 368 bool MinidumpModuleWriter::WriteObject(FileWriterInterface* file_writer) {
369 DCHECK_EQ(state(), kStateWritable); 369 DCHECK_EQ(state(), kStateWritable);
370 370
371 // This object doesn’t directly write anything itself. Its MINIDUMP_MODULE is 371 // This object doesn’t directly write anything itself. Its MINIDUMP_MODULE is
372 // written by its parent as part of a MINIDUMP_MODULE_LIST, and its children 372 // written by its parent as part of a MINIDUMP_MODULE_LIST, and its children
373 // are responsible for writing themselves. 373 // are responsible for writing themselves.
374 return true; 374 return true;
375 } 375 }
376 376
377 MinidumpModuleListWriter::MinidumpModuleListWriter() 377 MinidumpModuleListWriter::MinidumpModuleListWriter()
378 : MinidumpStreamWriter(), module_list_base_(), modules_() { 378 : MinidumpStreamWriter(), modules_(), module_list_base_() {
379 } 379 }
380 380
381 MinidumpModuleListWriter::~MinidumpModuleListWriter() { 381 MinidumpModuleListWriter::~MinidumpModuleListWriter() {
382 } 382 }
383 383
384 void MinidumpModuleListWriter::InitializeFromSnapshot( 384 void MinidumpModuleListWriter::InitializeFromSnapshot(
385 const std::vector<const ModuleSnapshot*>& module_snapshots) { 385 const std::vector<const ModuleSnapshot*>& module_snapshots) {
386 DCHECK_EQ(state(), kStateMutable); 386 DCHECK_EQ(state(), kStateMutable);
387 DCHECK(modules_.empty()); 387 DCHECK(modules_.empty());
388 388
(...skipping 59 matching lines...) Expand 10 before | Expand all | Expand 10 after
448 } 448 }
449 449
450 return file_writer->WriteIoVec(&iovecs); 450 return file_writer->WriteIoVec(&iovecs);
451 } 451 }
452 452
453 MinidumpStreamType MinidumpModuleListWriter::StreamType() const { 453 MinidumpStreamType MinidumpModuleListWriter::StreamType() const {
454 return kMinidumpStreamTypeModuleList; 454 return kMinidumpStreamTypeModuleList;
455 } 455 }
456 456
457 } // namespace crashpad 457 } // namespace crashpad
OLDNEW
« no previous file with comments | « minidump/minidump_module_writer.h ('k') | minidump/minidump_rva_list_writer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698